From: Christoph Hellwig <hch@infradead.org>
To: "Nirjhar Roy (IBM)" <nirjhar.roy.lists@gmail.com>
Cc: linux-xfs@vger.kernel.org, ritesh.list@gmail.com,
ojaswin@linux.ibm.com, djwong@kernel.org, hch@infradead.org
Subject: Re: [PATCH v1] xfs: Fix xfs_grow_last_rtg()
Date: Thu, 4 Dec 2025 01:36:38 -0800 [thread overview]
Message-ID: <aTFWJrOYXEeFX1kY@infradead.org> (raw)
In-Reply-To: <1e5fa7c83bd733871c04dd53b1060345599dcef9.1764765730.git.nirjhar.roy.lists@gmail.com>
On Wed, Dec 03, 2025 at 06:15:45PM +0530, Nirjhar Roy (IBM) wrote:
> The last rtg should be able to grow when the size of the
> last is less than (and not equal to) sb_rgextents.
> xfs_growfs with realtime groups fails without this
> patch. The reason is that, xfs_growfs_rtg() tries
> to grow the last rt group even when the last rt group
> is at its maximal size i.e, sb_rgextents. It fails with
> the following messages:
Please use up all 73 characters of the commit log to improve
readability.
The change looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
Can you submit a test case for this to xfstests?
next prev parent reply other threads:[~2025-12-04 9:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-03 12:45 [PATCH v1] xfs: Fix xfs_grow_last_rtg() Nirjhar Roy (IBM)
2025-12-04 9:36 ` Christoph Hellwig [this message]
2025-12-04 9:47 ` Nirjhar Roy (IBM)
2025-12-17 16:48 ` Nirjhar Roy (IBM)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aTFWJrOYXEeFX1kY@infradead.org \
--to=hch@infradead.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=nirjhar.roy.lists@gmail.com \
--cc=ojaswin@linux.ibm.com \
--cc=ritesh.list@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox