From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Pavel Reichl <preichl@redhat.com>,
linux-xfs@vger.kernel.org, chandanbabu@kernel.org,
sandeen@redhat.com, zlang@redhat.com, aalbersh@redhat.com
Subject: Re: [PATCH 1/1] mdrestore: fix restore_v2() superblock length check
Date: Tue, 9 Dec 2025 21:28:43 -0800 [thread overview]
Message-ID: <aTkFC2EWf5UX5y9w@infradead.org> (raw)
In-Reply-To: <20251209205017.GX89472@frogsfrogsfrogs>
On Tue, Dec 09, 2025 at 12:50:17PM -0800, Darrick J. Wong wrote:
> > - if (xme.xme_addr != 0 || xme.xme_len == 1 ||
> > + if (xme.xme_addr != 0 || cpu_to_be32(xme.xme_len) != 1 ||
>
> xme.xme_len is the ondisk value, so that should be be32_to_cpu().
>
> Otherwise the patch looks ok.
We really need to bring back regular sparse runs on the userspace
code. Let's see if I can get it back working..
next prev parent reply other threads:[~2025-12-10 5:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-09 20:26 [PATCH 0/1] mdrestore: fix restore_v2() superblock length check Pavel Reichl
2025-12-09 20:27 ` [PATCH 1/1] " Pavel Reichl
2025-12-09 20:50 ` Darrick J. Wong
2025-12-10 5:28 ` Christoph Hellwig [this message]
2025-12-10 6:00 ` Christoph Hellwig
2025-12-10 6:20 ` Darrick J. Wong
2025-12-10 22:53 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aTkFC2EWf5UX5y9w@infradead.org \
--to=hch@infradead.org \
--cc=aalbersh@redhat.com \
--cc=chandanbabu@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=preichl@redhat.com \
--cc=sandeen@redhat.com \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox