From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Andrey Albershteyn <aalbersh@redhat.com>,
xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfs_logprint: fix pointer bug
Date: Tue, 9 Dec 2025 22:28:35 -0800 [thread overview]
Message-ID: <aTkTEzOzDEYQuZX3@infradead.org> (raw)
In-Reply-To: <20251210062620.GC7753@frogsfrogsfrogs>
On Tue, Dec 09, 2025 at 10:26:20PM -0800, Darrick J. Wong wrote:
> On Tue, Dec 09, 2025 at 09:25:51PM -0800, Christoph Hellwig wrote:
> > On Tue, Dec 09, 2025 at 12:57:38PM -0800, Darrick J. Wong wrote:
> > > From: Darrick J. Wong <djwong@kernel.org>
> > >
> > > generic/055 captures a crash in xfs_logprint due to an incorrect
> > > refactoring trying to increment a pointer-to-pointer whereas before it
> > > incremented a pointer.
> >
> > Oops, sorry. This somehow did not show up in xfstests for me, where
> > did you run into it?
>
> FSTYP -- xfs (debug)
> PLATFORM -- Linux/x86_64 ca-nfsdev5-mtr00 6.18.0-xfsx #6 SMP PREEMPT_DYNAMIC Tue Dec 9 10:29:14 PST 2025
> MKFS_OPTIONS -- -f -m metadir=1,autofsck=1,uquota,gquota,pquota, -n size=8k, /dev/sdf
> MOUNT_OPTIONS -- /dev/sdf /opt
>
> > Looks good:
> >
> > Reviewed-by: Christoph Hellwig <hch@lst.de>
>
> Full log here
> https://djwong.org/fstests/output/ca-nfsdev5-mtr00/ca-nfsdev5-mtr00_2025-12-09_18-36-11/generic_055.full.br
Hmm, generic/044...
> user aibots
> pass suck
?
next prev parent reply other threads:[~2025-12-10 6:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-09 20:57 [PATCH] xfs_logprint: fix pointer bug Darrick J. Wong
2025-12-10 5:25 ` Christoph Hellwig
2025-12-10 6:26 ` Darrick J. Wong
2025-12-10 6:28 ` Christoph Hellwig [this message]
2025-12-10 11:10 ` Andrey Albershteyn
2025-12-10 15:44 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aTkTEzOzDEYQuZX3@infradead.org \
--to=hch@infradead.org \
--cc=aalbersh@redhat.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox