From: Christoph Hellwig <hch@infradead.org>
To: Luca Di Maio <luca.dimaio1@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-xfs@vger.kernel.org, dimitri.ledkov@chainguard.dev,
smoser@chainguard.dev, djwong@kernel.org
Subject: Re: [PATCH v1] xfs: test reproducible builds
Date: Fri, 12 Dec 2025 00:11:46 -0800 [thread overview]
Message-ID: <aTvOQqfpiJDCw7e5@infradead.org> (raw)
In-Reply-To: <hxcrjuiglg4qjn4qzgnwdtxpcv6v47rpjrkxaxhmanhxvvwzpx@rz4ytlnsjlcm>
On Fri, Dec 12, 2025 at 09:09:56AM +0100, Luca Di Maio wrote:
> > > +# Compute hash of the image file
> > > +_hash_image()
> > > +{
> > > + md5sum "$1" | awk '{print $1}'
> >
> > md5sum is pretty outdated. But we're using it in all kinds of other
> > places in xfstests, so I think for now this is the right thing to use
> > here. Eventually we should switch everything over to a more modern
> > checksum.
>
> Will move to sha256sum
I mean stick to md5sum for now. We should eventually migrate
all md5sum user over when introducing a new dependency anyway.
Combine that with proper helpers. If that's something you want
to do it would be great work, but it should not be requirement
for this.
next prev parent reply other threads:[~2025-12-12 8:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-11 17:25 [PATCH v1] xfs: test reproducible builds Luca Di Maio
2025-12-12 5:28 ` Christoph Hellwig
2025-12-12 8:09 ` Luca Di Maio
2025-12-12 8:11 ` Christoph Hellwig [this message]
2025-12-12 16:56 ` Luca Di Maio
2025-12-15 5:35 ` Christoph Hellwig
2025-12-15 14:45 ` Luca Di Maio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aTvOQqfpiJDCw7e5@infradead.org \
--to=hch@infradead.org \
--cc=dimitri.ledkov@chainguard.dev \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=luca.dimaio1@gmail.com \
--cc=smoser@chainguard.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox