Re: [PATCH v4] xfs: test reproducible builds

[Dave Chinner <david@fromorbit.com>]

On Mon, Dec 15, 2025 at 09:19:06PM -0800, Christoph Hellwig wrote:
> On Tue, Dec 16, 2025 at 09:57:14AM +1100, Dave Chinner wrote:
> > > +_cleanup() {
> > > +	rm -r -f "$PROTO_DIR" "$IMG_FILE"
> > > +}
> > 
> > After test specific cleanup, this needs to call _generic_cleanup()
> > to handle all the internal test state cleanup requirements.
> 
> There's no such thing as _generic_cleanup, and none of the
> _cleanup()-using tests that I've looked at recently hooks into any
> kind of generic cleanup routine.

Oh, I forgot that was one of the huge cleanups I have sitting around
in my local fstests tree. i.e.  making all the tests in fstests do
custom _cleanup() operations consistently and sanely.

It factors the _cleanup() function in common/preamble into
_generic_cleanup(), then fixes all the custom test _cleanup()
functions to do the custom test cleanup then call
_generic_cleanup() to do the rest.

The patch fixes a -lot- of random test cleanup failures when
cancelling a test run with ctrl-c because custom cleanup functions
are rarely tested....

Not a small patch, though, and likely needs to be updated because I
haven't touched it in a while:

278 files changed, 326 insertions(+), 1037 deletions(-)

-Dave.
-- 
Dave Chinner
david@fromorbit.com