From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Luca Di Maio <luca.dimaio1@gmail.com>,
linux-xfs@vger.kernel.org, djwong@kernel.org
Subject: Re: [PATCH v4] xfs: test reproducible builds
Date: Wed, 17 Dec 2025 08:43:47 +1100 [thread overview]
Message-ID: <aUHSk4SqAS2RS0Xy@dread.disaster.area> (raw)
In-Reply-To: <aUDryjk9wdZZQ5dz@infradead.org>
On Mon, Dec 15, 2025 at 09:19:06PM -0800, Christoph Hellwig wrote:
> On Tue, Dec 16, 2025 at 09:57:14AM +1100, Dave Chinner wrote:
> > > +_cleanup() {
> > > + rm -r -f "$PROTO_DIR" "$IMG_FILE"
> > > +}
> >
> > After test specific cleanup, this needs to call _generic_cleanup()
> > to handle all the internal test state cleanup requirements.
>
> There's no such thing as _generic_cleanup, and none of the
> _cleanup()-using tests that I've looked at recently hooks into any
> kind of generic cleanup routine.
I forgot to mention: the lack of _generic_cleanup() doesn't mean my
review comment should be ignored - the new custom _cleanup()
function above still needs to do the relevant generic cleanup work
that is done in common/preamble::_cleanup()...
-Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2025-12-16 21:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-15 19:33 [PATCH v4] xfs: test reproducible builds Luca Di Maio
2025-12-15 22:57 ` Dave Chinner
2025-12-16 5:19 ` Christoph Hellwig
2025-12-16 21:33 ` Dave Chinner
2025-12-16 21:43 ` Dave Chinner [this message]
2025-12-17 11:05 ` Luca Di Maio
2025-12-16 5:18 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aUHSk4SqAS2RS0Xy@dread.disaster.area \
--to=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
--cc=luca.dimaio1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox