From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: Carlos Maiolino <cem@kernel.org>,
Christoph Hellwig <hch@infradead.org>,
Kees Cook <kees@kernel.org>, Andy Shevchenko <andy@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-xfs@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH v3 1/2] lib: introduce simple error-checking wrapper for memparse()
Date: Thu, 8 Jan 2026 22:05:59 +0200 [thread overview]
Message-ID: <aWAOJwMURdOl_lqG@smile.fi.intel.com> (raw)
In-Reply-To: <20260108165216.1054625-1-dmantipov@yandex.ru>
On Thu, Jan 08, 2026 at 07:52:15PM +0300, Dmitry Antipov wrote:
> Introduce 'memvalue()' which uses 'memparse()' to parse a string
> with optional memory suffix into a non-negative number. If parsing
> has succeeded, returns 0 and stores the result at the location
> specified by the second argument. Otherwise returns -EINVAL and
> leaves the location untouched.
...
> +/**
> + * memvalue - Wrap memparse() with simple error detection
> + * @ptr: Where parse begins
> + * @valptr: Where to store result
> + *
> + * Unconditionally returns -EINVAL for a presumably negative value.
> + * Otherwise uses memparse() to parse a string into a number stored
> + * at @valptr and returns 0 or -EINVAL if an unrecognized character
> + * was encountered. For a non-zero return value, memory at @valptr
> + * is left untouched.
> + */
There are two problems with this kernel-doc:
1) inherited one with strange indentation;
2) missing Return section (run kernel-doc validator with -Wreturn, for example).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-01-08 20:06 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-08 16:52 [PATCH v3 1/2] lib: introduce simple error-checking wrapper for memparse() Dmitry Antipov
2026-01-08 16:52 ` [PATCH v3 2/2] xfs: adjust handling of a few numerical mount options Dmitry Antipov
2026-01-08 17:06 ` [PATCH v3 1/2] lib: introduce simple error-checking wrapper for memparse() Kees Cook
2026-01-08 17:42 ` Andrew Morton
2026-01-08 17:55 ` Kees Cook
2026-01-09 12:53 ` Carlos Maiolino
2026-01-08 20:05 ` Andy Shevchenko [this message]
2026-01-09 11:41 ` Dmitry Antipov
2026-01-09 17:09 ` Andy Shevchenko
2026-01-09 17:11 ` Andy Shevchenko
2026-01-11 0:01 ` Andrew Morton
2026-01-08 20:10 ` Andy Shevchenko
2026-01-09 11:05 ` Dmitry Antipov
2026-01-09 11:18 ` Andy Shevchenko
2026-01-20 0:06 ` Andrew Morton
2026-01-20 14:12 ` [PATCH v4 1/3] " Dmitry Antipov
2026-01-20 14:12 ` [PATCH v4 2/3] lib: fix a few comments to match kernel-doc -Wreturn style Dmitry Antipov
2026-01-20 14:47 ` Andy Shevchenko
2026-01-20 14:12 ` [PATCH v4 3/3] xfs: adjust handling of a few numerical mount options Dmitry Antipov
2026-01-20 14:59 ` Andy Shevchenko
2026-01-20 16:57 ` Dmitry Antipov
2026-01-20 21:49 ` Andy Shevchenko
2026-01-20 22:55 ` Darrick J. Wong
2026-01-21 5:21 ` Dmitry Antipov
2026-01-21 13:25 ` Andy Shevchenko
2026-01-20 14:45 ` [PATCH v4 1/3] lib: introduce simple error-checking wrapper for memparse() Andy Shevchenko
2026-01-20 14:46 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWAOJwMURdOl_lqG@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=akpm@linux-foundation.org \
--cc=andy@kernel.org \
--cc=cem@kernel.org \
--cc=dmantipov@yandex.ru \
--cc=hch@infradead.org \
--cc=kees@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox