From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Zorro Lang <zlang@redhat.com>, fstests <fstests@vger.kernel.org>,
xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfs/614: fix test for parent pointers
Date: Tue, 20 Jan 2026 22:46:43 -0800 [thread overview]
Message-ID: <aXB2U3_bHQou4e64@infradead.org> (raw)
In-Reply-To: <20260121012700.GF15541@frogsfrogsfrogs>
On Tue, Jan 20, 2026 at 05:27:00PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> Almost a decade ago, the initial rmap/reflink patches were merged with
> hugely overestimated log space reservations. Although we adjusted the
> actual runtime reservations a few years ago, we left the minimum log
> size calculations in place to avoid compatibility problems between newer
> mkfs and older kernels.
>
> With the introduction of parent pointers, we can finally use the more
> accurate reservations for minlog computations and mkfs can format
> smaller logs as a result. This causes the output of this test to
> change, though it wasn't needed until parent pointers were enabled by
> default.
Yeah, this has been failing for me for a while and I've been wanting
to look into it, I'm glad I don't have to :)
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2026-01-21 6:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-21 1:27 [PATCH] xfs/614: fix test for parent pointers Darrick J. Wong
2026-01-21 6:46 ` Christoph Hellwig [this message]
2026-01-21 15:34 ` Zorro Lang
2026-01-21 17:47 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXB2U3_bHQou4e64@infradead.org \
--to=hch@infradead.org \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox