public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Carlos Maiolino <cem@kernel.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: hch@lst.de, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: promote metadata directories and large block support
Date: Wed, 21 Jan 2026 12:45:25 +0100	[thread overview]
Message-ID: <aXC8SH8-zyV789X0@nidhogg.toxiclabs.cc> (raw)
In-Reply-To: <fbrzrkzqvwua64imzt2ii67uwre2fyqj47mogqj2gsrnlgk4my@k62y3yxnqm53>

On Wed, Jan 21, 2026 at 11:07:04AM +0100, Carlos Maiolino wrote:
> On Tue, Jan 20, 2026 at 10:45:40PM -0800, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> > 
> > Large block support was merged upstream in 6.12 (Dec 2024) and metadata
> > directories was merged in 6.13 (Jan 2025).  We've not received any
> > serious complaints about the ondisk formats of these two features in the
> > past year, so let's remove the experimental warnings.
> > 
> > Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
> > ---
> >  fs/xfs/xfs_message.h |    2 --
> >  fs/xfs/xfs_message.c |    8 --------
> >  fs/xfs/xfs_super.c   |    4 ----
> >  3 files changed, 14 deletions(-)
> 
> Looks good to me too.
> Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>

Sorry, this was supposed to be
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>

:)

> 
> > 
> > diff --git a/fs/xfs/xfs_message.h b/fs/xfs/xfs_message.h
> > index d68e72379f9dd5..49b0ef40d299de 100644
> > --- a/fs/xfs/xfs_message.h
> > +++ b/fs/xfs/xfs_message.h
> > @@ -93,8 +93,6 @@ void xfs_buf_alert_ratelimited(struct xfs_buf *bp, const char *rlmsg,
> >  enum xfs_experimental_feat {
> >  	XFS_EXPERIMENTAL_SHRINK,
> >  	XFS_EXPERIMENTAL_LARP,
> > -	XFS_EXPERIMENTAL_LBS,
> > -	XFS_EXPERIMENTAL_METADIR,
> >  	XFS_EXPERIMENTAL_ZONED,
> > 
> >  	XFS_EXPERIMENTAL_MAX,
> > diff --git a/fs/xfs/xfs_message.c b/fs/xfs/xfs_message.c
> > index 19aba2c3d52544..5ac0ac3d4f39f9 100644
> > --- a/fs/xfs/xfs_message.c
> > +++ b/fs/xfs/xfs_message.c
> > @@ -149,14 +149,6 @@ xfs_warn_experimental(
> >  			.opstate	= XFS_OPSTATE_WARNED_LARP,
> >  			.name		= "logged extended attributes",
> >  		},
> > -		[XFS_EXPERIMENTAL_LBS] = {
> > -			.opstate	= XFS_OPSTATE_WARNED_LBS,
> > -			.name		= "large block size",
> > -		},
> > -		[XFS_EXPERIMENTAL_METADIR] = {
> > -			.opstate	= XFS_OPSTATE_WARNED_METADIR,
> > -			.name		= "metadata directory tree",
> > -		},
> >  		[XFS_EXPERIMENTAL_ZONED] = {
> >  			.opstate	= XFS_OPSTATE_WARNED_ZONED,
> >  			.name		= "zoned RT device",
> > diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> > index bc71aa9dcee8d6..1f432d6645898e 100644
> > --- a/fs/xfs/xfs_super.c
> > +++ b/fs/xfs/xfs_super.c
> > @@ -1835,8 +1835,6 @@ xfs_fs_fill_super(
> >  			error = -ENOSYS;
> >  			goto out_free_sb;
> >  		}
> > -
> > -		xfs_warn_experimental(mp, XFS_EXPERIMENTAL_LBS);
> >  	}
> > 
> >  	/* Ensure this filesystem fits in the page cache limits */
> > @@ -1922,8 +1920,6 @@ xfs_fs_fill_super(
> >  			goto out_filestream_unmount;
> >  		}
> >  		xfs_warn_experimental(mp, XFS_EXPERIMENTAL_ZONED);
> > -	} else if (xfs_has_metadir(mp)) {
> > -		xfs_warn_experimental(mp, XFS_EXPERIMENTAL_METADIR);
> >  	}
> > 
> >  	if (xfs_has_reflink(mp)) {
> > 
> 

  reply	other threads:[~2026-01-21 11:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <a-5vQeWw6LnfGOvRdoGMbRxWS78ETAGa-UfYR5B0xb2DUlK_XJ43X9QV2mRZtYr-x9XokBbT2TNzi1NxvqD7vQ==@protonmail.internalid>
2026-01-21  6:45 ` [PATCH] xfs: promote metadata directories and large block support Darrick J. Wong
2026-01-21  6:57   ` Christoph Hellwig
2026-01-21 10:07   ` Carlos Maiolino
2026-01-21 11:45     ` Carlos Maiolino [this message]
2026-01-21 12:23   ` Carlos Maiolino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aXC8SH8-zyV789X0@nidhogg.toxiclabs.cc \
    --to=cem@kernel.org \
    --cc=djwong@kernel.org \
    --cc=hch@lst.de \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox