From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: cem@kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 3/3] xfs: add a method to replace shortform attrs
Date: Wed, 21 Jan 2026 07:22:56 -0800 [thread overview]
Message-ID: <aXDvUGGUGFzZF_Ts@infradead.org> (raw)
In-Reply-To: <176897695994.202851.7241999799670618810.stgit@frogsfrogsfrogs>
On Tue, Jan 20, 2026 at 10:40:02PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> If we're trying to replace an xattr in a shortform attr structure and
> the old entry fits the new entry, we can just memcpy and exit without
> having to delete, compact, and re-add the entry (or worse use the attr
> intent machinery). For parent pointers this only advantages renaming
> where the filename length stays the same (e.g. mv autoexec.bat
> scandisk.exe) but for regular xattrs it might be useful for updating
> security labels and the like.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2026-01-21 15:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-21 6:34 [PATCHSET 3/3] xfs: improve shortform attr performance Darrick J. Wong
2026-01-21 6:39 ` [PATCH 1/3] xfs: reduce xfs_attr_try_sf_addname parameters Darrick J. Wong
2026-01-21 15:11 ` Christoph Hellwig
2026-01-21 6:39 ` [PATCH 2/3] xfs: speed up parent pointer operations when possible Darrick J. Wong
2026-01-21 15:22 ` Christoph Hellwig
2026-01-21 18:06 ` Darrick J. Wong
2026-01-22 6:31 ` Christoph Hellwig
2026-01-21 6:40 ` [PATCH 3/3] xfs: add a method to replace shortform attrs Darrick J. Wong
2026-01-21 15:22 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-01-23 7:00 [PATCHSET 2/3] xfs: improve shortform attr performance Darrick J. Wong
2026-01-23 7:03 ` [PATCH 3/3] xfs: add a method to replace shortform attrs Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXDvUGGUGFzZF_Ts@infradead.org \
--to=hch@infradead.org \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox