public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
* [bug report] xfs/802 failure due to mssing fstype report by lsblk
@ 2026-02-06  8:40 Shinichiro Kawasaki
  2026-02-06 17:38 ` Darrick J. Wong
  0 siblings, 1 reply; 12+ messages in thread
From: Shinichiro Kawasaki @ 2026-02-06  8:40 UTC (permalink / raw)
  To: Darrick J. Wong, linux-xfs@vger.kernel.org; +Cc: hch

Hello Darrick,

Recently, my fstests run for null_blk (8GiB size) as SCRATCH_DEV failed at
xfs/802 [3]. I took a look and observed following points:

1) xfs_scrub_all command ran as expected. Even though SCRATCH_DEV is mounted,
   it did not scrub SCRATCH_DEV. Hence the failure.
2) xfs_scrub_all uses lsblk command to list all mounted xfs filesystems [1].
   However, lsblk command does not report that SCRATCH_DEV is mounted as xfs.
3) I leanred that lsblk command refers to udev database [2], and udev database
   sometimes fails to update the filesystem information. This is the case for
   the null_blk as SCRATCH_DEV on my test nodes.

Based on these observations, I think there are two points to improve:

1) I found "blkid -p" command reports that null_blk is mounted as xfs, even when
   lsblk does not report it. I think xfs_scrub_all can be modified to use
   "blkid -p" instead of lsblk to find out xfs filesystems mounted.
2) When there are other xfs filesystems on the test node than TEST_DEV or
   SCRATCH_DEV, xfs_scrub_all changes the status of them. This does not sound
   good to me since it affects system status out of the test targets block
   devices. I think he test case can be improved to check that there is no other
   xfs filesystems mounted other than TEST_DEV or SCRATCH_DEV/s. If not, the
   test case should be skipped.

At this moment, I don't have time to create patches for the improvements above.
If anyone can work on them, it will be appreciated.

[1] https://git.kernel.org/pub/scm/fs/xfs/xfsprogs-dev.git/tree/scrub/xfs_scrub_all.py.in#n55
[2] https://unix.stackexchange.com/questions/642598/lsblk-file-system-type-not-appears-from-lsblk#642600

[3] xfs/802 failure console message

xfs/802            - output mismatch (see /home/shin/kts/kernel-test-suite/src/xfstests/results//xfs/802.out.bad)
    --- tests/xfs/802.out       2026-02-04 20:44:52.254221182 +0900
    +++ /home/shin/kts/kernel-test-suite/src/xfstests/results//xfs/802.out.bad  2026-02-06 17:04:24.336536185 +0900
    @@ -2,4 +2,7 @@
     Format and populate
     Scrub Scratch FS
     Scrub Everything
    +Health status has not been collected for this filesystem.
    +Please run xfs_scrub(8) to remedy this situation.
    +cannot find evidence that /var/kts/scratch was scrubbed
     Scrub Done
    ...
    (Run 'diff -u /home/shin/kts/kernel-test-suite/src/xfstests/tests/xfs/802.out /home/shin/kts/kernel-test-suite/src/xfstests/results//xfs/802.out.bad'  to see the entire diff)

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2026-02-14  7:39 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-06  8:40 [bug report] xfs/802 failure due to mssing fstype report by lsblk Shinichiro Kawasaki
2026-02-06 17:38 ` Darrick J. Wong
2026-02-09  2:50   ` Shinichiro Kawasaki
2026-02-09  6:07     ` Darrick J. Wong
2026-02-09  6:28       ` hch
2026-02-09  7:54         ` Shinichiro Kawasaki
2026-02-10  2:00           ` Darrick J. Wong
2026-02-10  6:17             ` Darrick J. Wong
2026-02-10  6:19             ` Shinichiro Kawasaki
2026-02-13 22:14               ` Darrick J. Wong
2026-02-14  6:39                 ` Shinichiro Kawasaki
2026-02-14  7:39                   ` Darrick J. Wong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox