Linux XFS filesystem development
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: "Марк Коренберг" <socketpair@gmail.com>, linux-xfs@vger.kernel.org
Subject: Re: [RFE] xfs_growfs: option to clamp growth to an AG boundary
Date: Tue, 24 Feb 2026 07:01:11 -0800	[thread overview]
Message-ID: <aZ29NxAM6CpGXVWl@infradead.org> (raw)
In-Reply-To: <20260223230840.GD2390353@frogsfrogsfrogs>

On Mon, Feb 23, 2026 at 03:08:40PM -0800, Darrick J. Wong wrote:
> On Tue, Feb 24, 2026 at 12:29:49AM +0500, Марк Коренберг wrote:
> > ```
> > cp: failed to clone
> > '/run/ideco-overlay-dir/ideco-trash-o4ut52ue/upperdir/var/lib/clickhouse/store/e2b/e2bdef56-6be8-40bf-8fab-d8fb2e9fdd94/90-20250905_11925_11925_0/primary.cidx'
> > from '/run/ideco-overlay-dir/storage/ideco-ngfw-19-7-19/upperdir/var/lib/clickhouse/store/e2b/e2bdef56-6be8-40bf-8fab-d8fb2e9fdd94/90-20250905_11925_11925_0/primary.cidx':
> > No space left on device
> 
> Ah, that.  coreutils seems to think that FICLONE returning ENOSPC is a
> fatal error.  I wonder if we need to amend the ficlone manpage to state
> that ENOSPC can happen if there's not enough space in an AG to clone and
> that the caller might try a regular copy; or just change xfs to return a
> different errno?

I think the problem is that we report ENOSPC for this.  The historic
error code coming from the old btrfs days is EINVAL for "can't support
this for random unlisted reason", which btrfs does for example for
inline extents.  We really should turn ENOSPC into that.


  parent reply	other threads:[~2026-02-24 15:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-23  9:48 [RFE] xfs_growfs: option to clamp growth to an AG boundary Марк Коренберг
2026-02-23 16:23 ` Darrick J. Wong
2026-02-23 19:29   ` Марк Коренберг
2026-02-23 23:08     ` Darrick J. Wong
2026-02-24  6:17       ` Марк Коренберг
2026-02-24 15:01       ` Christoph Hellwig [this message]
2026-02-24 19:44         ` Darrick J. Wong
2026-02-24 22:25           ` Darrick J. Wong
2026-02-25 14:21             ` Christoph Hellwig
2026-02-24 15:02 ` Christoph Hellwig
2026-02-24 19:49   ` Darrick J. Wong
  -- strict thread matches above, loose matches on Subject: below --
2026-02-25  8:21 Lukas Herbolt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aZ29NxAM6CpGXVWl@infradead.org \
    --to=hch@infradead.org \
    --cc=djwong@kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=socketpair@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox