* [PATCH] xfs: remove scratch field from struct xfs_gc_bio
@ 2026-02-25 22:46 Damien Le Moal
2026-02-26 5:21 ` Darrick J. Wong
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Damien Le Moal @ 2026-02-25 22:46 UTC (permalink / raw)
To: linux-xfs, Carlos Maiolino
The scratch field in struct xfs_gc_bio is unused. Remove it.
Fixes: 102f444b57b3 ("xfs: rework zone GC buffer management")
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
---
fs/xfs/xfs_zone_gc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/xfs/xfs_zone_gc.c b/fs/xfs/xfs_zone_gc.c
index 48c6cf584447..d78e29cdcc45 100644
--- a/fs/xfs/xfs_zone_gc.c
+++ b/fs/xfs/xfs_zone_gc.c
@@ -96,7 +96,6 @@ struct xfs_gc_bio {
*/
xfs_fsblock_t old_startblock;
xfs_daddr_t new_daddr;
- struct xfs_zone_scratch *scratch;
/* Are we writing to a sequential write required zone? */
bool is_seq;
@@ -779,7 +778,6 @@ xfs_zone_gc_split_write(
ihold(VFS_I(chunk->ip));
split_chunk->ip = chunk->ip;
split_chunk->is_seq = chunk->is_seq;
- split_chunk->scratch = chunk->scratch;
split_chunk->offset = chunk->offset;
split_chunk->len = split_len;
split_chunk->old_startblock = chunk->old_startblock;
--
2.53.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] xfs: remove scratch field from struct xfs_gc_bio
2026-02-25 22:46 [PATCH] xfs: remove scratch field from struct xfs_gc_bio Damien Le Moal
@ 2026-02-26 5:21 ` Darrick J. Wong
2026-02-26 15:31 ` Christoph Hellwig
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Darrick J. Wong @ 2026-02-26 5:21 UTC (permalink / raw)
To: Damien Le Moal; +Cc: linux-xfs, Carlos Maiolino
On Thu, Feb 26, 2026 at 07:46:46AM +0900, Damien Le Moal wrote:
> The scratch field in struct xfs_gc_bio is unused. Remove it.
>
> Fixes: 102f444b57b3 ("xfs: rework zone GC buffer management")
> Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Looks good to me and assuming the bots don't scream,
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
--D
> ---
> fs/xfs/xfs_zone_gc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/xfs/xfs_zone_gc.c b/fs/xfs/xfs_zone_gc.c
> index 48c6cf584447..d78e29cdcc45 100644
> --- a/fs/xfs/xfs_zone_gc.c
> +++ b/fs/xfs/xfs_zone_gc.c
> @@ -96,7 +96,6 @@ struct xfs_gc_bio {
> */
> xfs_fsblock_t old_startblock;
> xfs_daddr_t new_daddr;
> - struct xfs_zone_scratch *scratch;
>
> /* Are we writing to a sequential write required zone? */
> bool is_seq;
> @@ -779,7 +778,6 @@ xfs_zone_gc_split_write(
> ihold(VFS_I(chunk->ip));
> split_chunk->ip = chunk->ip;
> split_chunk->is_seq = chunk->is_seq;
> - split_chunk->scratch = chunk->scratch;
> split_chunk->offset = chunk->offset;
> split_chunk->len = split_len;
> split_chunk->old_startblock = chunk->old_startblock;
> --
> 2.53.0
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] xfs: remove scratch field from struct xfs_gc_bio
2026-02-25 22:46 [PATCH] xfs: remove scratch field from struct xfs_gc_bio Damien Le Moal
2026-02-26 5:21 ` Darrick J. Wong
@ 2026-02-26 15:31 ` Christoph Hellwig
2026-02-26 15:56 ` Carlos Maiolino
2026-03-05 9:48 ` Carlos Maiolino
3 siblings, 0 replies; 5+ messages in thread
From: Christoph Hellwig @ 2026-02-26 15:31 UTC (permalink / raw)
To: Damien Le Moal; +Cc: linux-xfs, Carlos Maiolino
On Thu, Feb 26, 2026 at 07:46:46AM +0900, Damien Le Moal wrote:
> The scratch field in struct xfs_gc_bio is unused. Remove it.
>
> Fixes: 102f444b57b3 ("xfs: rework zone GC buffer management")
> Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] xfs: remove scratch field from struct xfs_gc_bio
2026-02-25 22:46 [PATCH] xfs: remove scratch field from struct xfs_gc_bio Damien Le Moal
2026-02-26 5:21 ` Darrick J. Wong
2026-02-26 15:31 ` Christoph Hellwig
@ 2026-02-26 15:56 ` Carlos Maiolino
2026-03-05 9:48 ` Carlos Maiolino
3 siblings, 0 replies; 5+ messages in thread
From: Carlos Maiolino @ 2026-02-26 15:56 UTC (permalink / raw)
To: Damien Le Moal; +Cc: linux-xfs
On Thu, Feb 26, 2026 at 07:46:46AM +0900, Damien Le Moal wrote:
> The scratch field in struct xfs_gc_bio is unused. Remove it.
>
> Fixes: 102f444b57b3 ("xfs: rework zone GC buffer management")
> Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Looks good,
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
> ---
> fs/xfs/xfs_zone_gc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/xfs/xfs_zone_gc.c b/fs/xfs/xfs_zone_gc.c
> index 48c6cf584447..d78e29cdcc45 100644
> --- a/fs/xfs/xfs_zone_gc.c
> +++ b/fs/xfs/xfs_zone_gc.c
> @@ -96,7 +96,6 @@ struct xfs_gc_bio {
> */
> xfs_fsblock_t old_startblock;
> xfs_daddr_t new_daddr;
> - struct xfs_zone_scratch *scratch;
>
> /* Are we writing to a sequential write required zone? */
> bool is_seq;
> @@ -779,7 +778,6 @@ xfs_zone_gc_split_write(
> ihold(VFS_I(chunk->ip));
> split_chunk->ip = chunk->ip;
> split_chunk->is_seq = chunk->is_seq;
> - split_chunk->scratch = chunk->scratch;
> split_chunk->offset = chunk->offset;
> split_chunk->len = split_len;
> split_chunk->old_startblock = chunk->old_startblock;
> --
> 2.53.0
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] xfs: remove scratch field from struct xfs_gc_bio
2026-02-25 22:46 [PATCH] xfs: remove scratch field from struct xfs_gc_bio Damien Le Moal
` (2 preceding siblings ...)
2026-02-26 15:56 ` Carlos Maiolino
@ 2026-03-05 9:48 ` Carlos Maiolino
3 siblings, 0 replies; 5+ messages in thread
From: Carlos Maiolino @ 2026-03-05 9:48 UTC (permalink / raw)
To: linux-xfs, Damien Le Moal
On Thu, 26 Feb 2026 07:46:46 +0900, Damien Le Moal wrote:
> The scratch field in struct xfs_gc_bio is unused. Remove it.
>
>
Applied to for-next, thanks!
[1/1] xfs: remove scratch field from struct xfs_gc_bio
commit: 6270b8ac2f41858952074b23c2d3d9aa2fe1bfa9
Best regards,
--
Carlos Maiolino <cem@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-03-05 9:48 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-25 22:46 [PATCH] xfs: remove scratch field from struct xfs_gc_bio Damien Le Moal
2026-02-26 5:21 ` Darrick J. Wong
2026-02-26 15:31 ` Christoph Hellwig
2026-02-26 15:56 ` Carlos Maiolino
2026-03-05 9:48 ` Carlos Maiolino
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox