Re: [PATCH 3/4] xfs: factor out xfs_attr3_leaf_init

[Long Li <leo.lilong@huawei.com>]

On Mon, Mar 09, 2026 at 09:44:37AM -0700, Darrick J. Wong wrote:
> On Mon, Mar 09, 2026 at 04:27:51PM +0800, Long Li wrote:
> > Factor out wrapper xfs_attr3_leaf_init function, which exported for
> > external use.
> > 
> > Signed-off-by: Long Li <leo.lilong@huawei.com>
> > ---
> >  fs/xfs/libxfs/xfs_attr_leaf.c | 20 ++++++++++++++++++++
> >  fs/xfs/libxfs/xfs_attr_leaf.h |  3 +++
> >  2 files changed, 23 insertions(+)
> > 
> > diff --git a/fs/xfs/libxfs/xfs_attr_leaf.c b/fs/xfs/libxfs/xfs_attr_leaf.c
> > index 47f48ae555c0..6599b53f4822 100644
> > --- a/fs/xfs/libxfs/xfs_attr_leaf.c
> > +++ b/fs/xfs/libxfs/xfs_attr_leaf.c
> > @@ -1415,6 +1415,26 @@ xfs_attr3_leaf_create(
> >  	return 0;
> >  }
> >  
> > +/*
> > + * Wrapper function of initializing contents of a leaf, export for external use.
> > + */
> > +int
> > +xfs_attr3_leaf_init(
> > +	struct xfs_trans	*tp,
> > +	struct xfs_inode	*dp,
> > +	xfs_dablk_t		blkno)
> > +{
> > +	struct xfs_buf		*bp = NULL;
> > +	struct xfs_da_args	args;
> 
> Same thing as previous patch:
> 
> 	struct xfs_da_args	args = {
> 		.trans		= tp,
> 		...
> 	};
> 
> Also I think this should just go in whichever patch uses the new
> function since this is pretty trivial.
> 
 Thanks for point that, it will be update in next version.

 Long Li