Re: [PATCH 22/26] xfs_io: add listmount command

[Christoph Hellwig <hch@infradead.org>]

On Mon, Mar 02, 2026 at 04:39:33PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
> 
> Add a command to list all mounts, now that we use this in
> xfs_healer_start.

> +/* copied from linux/mount.h in linux 6.18 */
> +struct statmount_fixed {

Shouldn't this use the kernel uapi header and/or a copy of it?

And be split out of the .c file into a separate header for maintainance
and eventually nuking once the kernel requirement becomes new enough?

> +static int
> +listmount(
> +	const struct mnt_id_req	*req,
> +	uint64_t		*mnt_ids,
> +	size_t			nr_mnt_ids)
> +{
> +	return syscall(SYS_listmount, req, mnt_ids, nr_mnt_ids, 0);
> +}

Same comment as for the other listmount instance here.

> +
> +static int
> +statmount(
> +	const struct mnt_id_req	*req,
> +	struct statmount_fixed	*smbuf,
> +	size_t			smbuf_size)
> +{
> +	return syscall(SYS_statmount, req, smbuf, smbuf_size, 0);
> +}

and similar here.