From: Christoph Hellwig <hch@infradead.org>
To: Long Li <leo.lilong@huawei.com>
Cc: djwong@kernel.org, cem@kernel.org, linux-xfs@vger.kernel.org,
david@fromorbit.com, yi.zhang@huawei.com, houtao1@huawei.com,
yangerkun@huawei.com, lonuxli.64@gmail.com
Subject: Re: [PATCH 1/2] xfs: remove redundant set null for ip->i_itemp
Date: Thu, 5 Mar 2026 06:06:31 -0800 [thread overview]
Message-ID: <aamN57CqiAXJQH39@infradead.org> (raw)
In-Reply-To: <20260305084922.800699-2-leo.lilong@huawei.com>
On Thu, Mar 05, 2026 at 04:49:21PM +0800, Long Li wrote:
> ip->i_itemp has been set null in xfs_inode_item_destroy(), so there is
> no need set it null again in xfs_inode_free_callback().
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2026-03-05 14:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-05 8:49 [PATCH 0/2] xfs: code cleanup and item deletion fix Long Li
2026-03-05 8:49 ` [PATCH 1/2] xfs: remove redundant set null for ip->i_itemp Long Li
2026-03-05 14:06 ` Christoph Hellwig [this message]
2026-03-10 8:28 ` Carlos Maiolino
2026-03-05 8:49 ` [PATCH 2/2] xfs: ensure dquot item is deleted from AIL only after log shutdown Long Li
2026-03-05 14:06 ` Christoph Hellwig
2026-03-10 8:39 ` Carlos Maiolino
2026-03-12 8:38 ` [PATCH 0/2] xfs: code cleanup and item deletion fix Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aamN57CqiAXJQH39@infradead.org \
--to=hch@infradead.org \
--cc=cem@kernel.org \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=houtao1@huawei.com \
--cc=leo.lilong@huawei.com \
--cc=linux-xfs@vger.kernel.org \
--cc=lonuxli.64@gmail.com \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox