From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: aalbersh@kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 3/4] mkfs: fix protofile data corruption when in/out file block sizes don't match
Date: Thu, 5 Mar 2026 06:04:43 -0800 [thread overview]
Message-ID: <aamNe8Z_a-BEyxhV@infradead.org> (raw)
In-Reply-To: <177268457065.1999857.17773222106097875153.stgit@frogsfrogsfrogs>
> + hole_pos = roundup_64(hole_pos, mp->m_sb.sb_blocksize);
> + if (hole_pos > statbuf.st_size)
> + hole_pos = statbuf.st_size;
use min() here?
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2026-03-05 14:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-05 4:24 [PATCHSET] xfsprogs: various bug fixes for 6.19 Darrick J. Wong
2026-03-05 4:24 ` [PATCH 1/4] misc: fix a few memory leaks Darrick J. Wong
2026-03-05 14:03 ` Christoph Hellwig
2026-03-05 4:24 ` [PATCH 2/4] libxfs: fix data corruption bug in libxfs_file_write Darrick J. Wong
2026-03-05 7:46 ` Holger Hoffstätte
2026-03-05 15:56 ` Darrick J. Wong
2026-03-05 14:04 ` Christoph Hellwig
2026-03-05 4:24 ` [PATCH 3/4] mkfs: fix protofile data corruption when in/out file block sizes don't match Darrick J. Wong
2026-03-05 14:04 ` Christoph Hellwig [this message]
2026-03-05 4:24 ` [PATCH 4/4] mkfs: fix log sunit automatic configuration Darrick J. Wong
2026-03-05 14:05 ` Christoph Hellwig
2026-03-05 22:56 ` Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2026-03-10 3:24 [PATCHSET v2] xfsprogs: various bug fixes for 6.19 Darrick J. Wong
2026-03-10 3:25 ` [PATCH 3/4] mkfs: fix protofile data corruption when in/out file block sizes don't match Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aamNe8Z_a-BEyxhV@infradead.org \
--to=hch@infradead.org \
--cc=aalbersh@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox