From: Dave Chinner <dgc@kernel.org>
To: Lukas Herbolt <lukas@herbolt.com>
Cc: linux-xfs@vger.kernel.org, cem@kernel.org, hch@infradead.org,
djwong@kernel.org, pankaj.raghav@linux.dev,
Pankaj Raghav <p.raghav@samsung.com>
Subject: Re: [PATCH v12 2/2] xfs: add FALLOC_FL_WRITE_ZEROES to XFS code base
Date: Wed, 11 Mar 2026 11:19:58 +1100 [thread overview]
Message-ID: <abC1LvRElctaHPe5@dread> (raw)
In-Reply-To: <20260310194245.848034-2-lukas@herbolt.com>
On Tue, Mar 10, 2026 at 08:42:46PM +0100, Lukas Herbolt wrote:
> Add support for FALLOC_FL_WRITE_ZEROES if the underlying device
> enable the unmap write zeroes operation.
>
> Co-developed-by: Pankaj Raghav <p.raghav@samsung.com>
> Signed-off-by: Pankaj Raghav <p.raghav@samsung.com>
> Signed-off-by: Lukas Herbolt <lukas@herbolt.com>
> ---
> v12 changes:
> split from xfs_falloc_zero_range() into separate function
> fs/xfs/xfs_file.c | 49 ++++++++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 48 insertions(+), 1 deletion(-)
Ugh, I just reviewed v11 and pointed out how unnecessarily complex
this new "three phase" method is. Please given people a chance to
review the code by waiting a couple of days before posting a new
version....
My comments against v11 are still relevant; working around low level
truncate issues when calling truncate to transactionally update the
file size is not necessary is less than ideal.
-Dave.
--
Dave Chinner
dgc@kernel.org
prev parent reply other threads:[~2026-03-11 0:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 19:42 [PATCH v12 2/2] xfs: add FALLOC_FL_WRITE_ZEROES to XFS code base Lukas Herbolt
2026-03-10 20:52 ` Darrick J. Wong
2026-03-11 0:19 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abC1LvRElctaHPe5@dread \
--to=dgc@kernel.org \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
--cc=lukas@herbolt.com \
--cc=p.raghav@samsung.com \
--cc=pankaj.raghav@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox