Re: [PATCH v2 3/4] xfs: factor out xfs_attr3_leaf_init

[Long Li <leo.lilong@huawei.com>]

On Fri, Mar 13, 2026 at 08:04:17AM -0700, Darrick J. Wong wrote:
> On Thu, Mar 12, 2026 at 04:57:59PM +0800, Long Li wrote:
> > Factor out wrapper xfs_attr3_leaf_init function, which exported for
> > external use.
> > 
> > Signed-off-by: Long Li <leo.lilong@huawei.com>
> > ---
> >  fs/xfs/libxfs/xfs_attr_leaf.c | 22 ++++++++++++++++++++++
> >  fs/xfs/libxfs/xfs_attr_leaf.h |  3 +++
> >  2 files changed, 25 insertions(+)
> > 
> > diff --git a/fs/xfs/libxfs/xfs_attr_leaf.c b/fs/xfs/libxfs/xfs_attr_leaf.c
> > index 47f48ae555c0..96a65141e812 100644
> > --- a/fs/xfs/libxfs/xfs_attr_leaf.c
> > +++ b/fs/xfs/libxfs/xfs_attr_leaf.c
> > @@ -1415,6 +1415,28 @@ xfs_attr3_leaf_create(
> >  	return 0;
> >  }
> >  
> > +/*
> > + * Create and initialize an empty attr leaf block at blkno, and attach the
> > + * buffer to tp.
> 
> Not sure why we "create and initialize" here -- there's already a block
> mapped at @blkno and we're rewriting it with a leaf header, right?
> 
> /*
>  * Reinitialize an existing attr fork block as an empty leaf, and
>  * attach the buffer to tp.
>  */
> 
> With that changed,
> Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
> 
> --D

Thank you for the review. I'll update the comment to use the clearer format
you suggested. and appreciate the guidance on improving the documentation
clarity.

Thanks,
Long Li