From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Pavel Reichl <preichl@redhat.com>,
"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH v2 1/1] mkfs: Fix memory leak
Date: Wed, 25 May 2022 07:24:06 +0000 [thread overview]
Message-ID: <ad1f06b5-b4af-1b56-6337-0dee850c940c@nvidia.com> (raw)
In-Reply-To: <20220524220509.967287-2-preichl@redhat.com>
On 5/24/22 15:05, Pavel Reichl wrote:
> 'value' is allocated by strdup() in getstr(). It
> needs to be freed as we do not keep any permanent
> reference to it.
>
> Signed-off-by: Pavel Reichl <preichl@redhat.com>
> Reviewed-by: Darrick J. Wong <djwong@kernel.org>
> ---
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
prev parent reply other threads:[~2022-05-25 7:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-24 22:05 [PATCH v2 0/1] mkfs: Fix memory leark Pavel Reichl
2022-05-24 22:05 ` [PATCH v2 1/1] mkfs: Fix memory leak Pavel Reichl
2022-05-25 7:24 ` Chaitanya Kulkarni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad1f06b5-b4af-1b56-6337-0dee850c940c@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=linux-xfs@vger.kernel.org \
--cc=preichl@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).