From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Zorro Lang <zlang@kernel.org>,
linux-xfs@vger.kernel.org, Eric Sandeen <sandeen@redhat.com>
Subject: Re: [PATCH 2/2] mkfs: unify validation behavior for data, log and rt dev
Date: Mon, 6 Apr 2026 22:38:44 -0700 [thread overview]
Message-ID: <adSYZMTNXGOy9E-2@infradead.org> (raw)
In-Reply-To: <20260406153726.GD1048989@frogsfrogsfrogs>
On Mon, Apr 06, 2026 at 08:37:26AM -0700, Darrick J. Wong wrote:
> I think this rearrangement preserves all the datadev validation checks,
> then makes the log/rt validation code look almost the same, except for
> which variables are accessed. That change looks ok to me, but it's
> disappointing that there isn't a third patch that actually refactors all
> three into a single function, seeing as the commit message talks about
> unifying the implementations.
Agreed, it would be really helpful to share the code here.
prev parent reply other threads:[~2026-04-07 5:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-04 16:36 [PATCH 0/2] xfsprogs/mkfs: consolidate subvolume validation logic for file images Zorro Lang
2026-04-04 16:36 ` [PATCH 1/2] mkfs: fix assertion failure on empty data file Zorro Lang
2026-04-06 15:26 ` Darrick J. Wong
2026-04-04 16:36 ` [PATCH 2/2] mkfs: unify validation behavior for data, log and rt dev Zorro Lang
2026-04-06 15:37 ` Darrick J. Wong
2026-04-07 5:38 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adSYZMTNXGOy9E-2@infradead.org \
--to=hch@infradead.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox