From: Ziyang Zhang <ZiyangZhang@linux.alibaba.com>
To: Zorro Lang <zlang@redhat.com>
Cc: fstests@vger.kernel.org, linux-xfs@vger.kernel.org,
hsiangkao@linux.alibaba.com,
"Darrick J. Wong" <djwong@kernel.org>
Subject: Re: [PATCH V5 2/2] common/populate: Ensure that S_IFDIR.FMT_BTREE is in btree format
Date: Mon, 12 Dec 2022 11:43:40 +0800 [thread overview]
Message-ID: <ada237c4-65e2-3125-1a60-cfaa17efd83a@linux.alibaba.com> (raw)
In-Reply-To: <20221211110125.zpc4csv6hw5ibsbu@zlang-mailbox>
On 2022/12/11 19:01, Zorro Lang wrote:
> Yes, and this helper's name should be _xfs_get_inode_core_bytes(), not
> _xfs_inode_core_bytes(). I didn't find _xfs_inode_core_bytes from current
> fstests. So it should be:
>
> local icore_size="$(_xfs_get_inode_core_bytes $SCRATCH_MNT)"
>
> Hi Ziyang,
>
> Please modify this place, and check all other places which call
> _xfs_get_inode_core_bytes and _xfs_get_inode_size, to make sure
> they're all changed correctly.
>
> Thanks,
> Zorro
Hi Zorro,
You are correct. Sorry for my mistake.
I should use _xfs_get_inode_core_bytes here and add a path
argument($SCRATCH_MNT). I will send a new version.
Regards,
Zhang
prev parent reply other threads:[~2022-12-12 3:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-08 7:28 [PATCH V5 0/2] cleanup and bugfix for xfs tests related to btree format Ziyang Zhang
2022-12-08 7:28 ` [PATCH V5 1/2] common/xfs: Add a helper to export inode core size Ziyang Zhang
2022-12-08 7:28 ` [PATCH V5 2/2] common/populate: Ensure that S_IFDIR.FMT_BTREE is in btree format Ziyang Zhang
2022-12-09 16:37 ` Darrick J. Wong
2022-12-10 13:57 ` Zorro Lang
2022-12-11 2:30 ` Darrick J. Wong
2022-12-11 11:01 ` Zorro Lang
2022-12-11 11:23 ` Zorro Lang
2022-12-11 19:19 ` Darrick J. Wong
2022-12-12 3:43 ` Ziyang Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ada237c4-65e2-3125-1a60-cfaa17efd83a@linux.alibaba.com \
--to=ziyangzhang@linux.alibaba.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=hsiangkao@linux.alibaba.com \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox