From: Yuto Ohnuki <ytohnuki@amazon.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Carlos Maiolino <cem@kernel.org>, <linux-xfs@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] xfs: check da node block pad field during scrub
Date: Wed, 8 Apr 2026 18:14:54 +0100 [thread overview]
Message-ID: <adaNDr-BeEu04Px7@c889f3b07a0a.ant.amazon.com> (raw)
In-Reply-To: <20260406152304.GB1048989@frogsfrogsfrogs>
On Mon, Apr 06, 2026 at 08:23:04AM -0700, Darrick J. Wong wrote:
Thank you for reviewing this patch as well.
> Same question as the previous patch -- does xfs_da3_node_create actually
> zero out the pad field?
Yes, xfs_da3_node_create already does
memset(hdr3, 0, sizeof(struct xfs_da3_node_hdr)) which covers __pad32.
> and same comment about how you can only set xchk_da_set_preen if old
> kernels were ok with nonzero __pad32.
>
> --D
>
Understood. I'll switch to xchk_da_set_preen as well.
I'll send a v2 with this change.
Thanks,
Yuto
Amazon Web Services EMEA SARL, 38 avenue John F. Kennedy, L-1855 Luxembourg, R.C.S. Luxembourg B186284
Amazon Web Services EMEA SARL, Irish Branch, One Burlington Plaza, Burlington Road, Dublin 4, Ireland, branch registration number 908705
prev parent reply other threads:[~2026-04-08 17:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-04 14:30 [PATCH] xfs: check da node block pad field during scrub Yuto Ohnuki
2026-04-06 15:23 ` Darrick J. Wong
2026-04-08 17:14 ` Yuto Ohnuki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adaNDr-BeEu04Px7@c889f3b07a0a.ant.amazon.com \
--to=ytohnuki@amazon.com \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox