From: Christoph Hellwig <hch@infradead.org>
To: Ravi Singh <ravising@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
djwong@kernel.org, dchinner@redhat.com, esandeen@redhat.com,
cem@kernel.org
Subject: Re: [PATCH] xfs: flush delalloc blocks on ENOSPC when creating symlinks
Date: Wed, 15 Apr 2026 22:13:35 -0700 [thread overview]
Message-ID: <aeBv_xvDTmuzEhV1@infradead.org> (raw)
In-Reply-To: <CAF-d4OvKZOsez5589KUYTjRz05PQHCQ-uRkXu-3iaO3tOjcavA@mail.gmail.com>
On Wed, Apr 15, 2026 at 06:54:00PM +0530, Ravi Singh wrote:
> > While we're at it - do we also want it for tempfiles and scrub?
> > i.e., should we move this logic into xfs_trans_alloc_icreate,
> > similar to the quota logic?
> >
> tmpfiles and scrub tempfiles are created without
> directory entries, so they don't need a new directory block
> allocation and don't hit this ENOSPC path.
But we still ned the ialloc space reservation for all these cases.
> As for moving the logic into xfs_trans_alloc_icreate(),
> xfs_flush_inodes() is a heavier operation (sync_inodes_sb).
> Pushing it down into xfs_trans_alloc_icreate() would make every
> caller pay for that flush, including paths that don't need it.
Only if we git enospc and need to restart the underlying
xfs_trans_alloc call, similar to how it handles quotas.
prev parent reply other threads:[~2026-04-16 5:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-15 7:16 [PATCH] xfs: flush delalloc blocks on ENOSPC when creating symlinks Ravi Singh
2026-04-15 7:20 ` Christoph Hellwig
2026-04-15 13:24 ` Ravi Singh
2026-04-15 14:14 ` Eric Sandeen
2026-04-16 5:13 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeBv_xvDTmuzEhV1@infradead.org \
--to=hch@infradead.org \
--cc=cem@kernel.org \
--cc=dchinner@redhat.com \
--cc=djwong@kernel.org \
--cc=esandeen@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ravising@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox