From: Damien Le Moal <dlemoal@kernel.org>
To: Christoph Hellwig <hch@lst.de>, Carlos Maiolino <cem@kernel.org>
Cc: Hans Holmberg <hans.holmberg@wdc.com>,
"Darrick J. Wong" <djwong@kernel.org>,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/3] xfs: remove xfs_last_used_zone
Date: Tue, 19 Aug 2025 14:56:36 +0900 [thread overview]
Message-ID: <aeaa9d62-cff3-49eb-835b-3d0e3d7180fc@kernel.org> (raw)
In-Reply-To: <20250818050716.1485521-2-hch@lst.de>
On 8/18/25 14:06, Christoph Hellwig wrote:
> This was my first attempt at caching the last used zone. But it turns out
> for O_DIRECT or RWF_DONTCACHE that operate concurrently or in very short
> sequence, the bmap btree does not record a written extent yet, so it fails.
> Because it then still finds the last written zone it can lead to a weird
> ping-pong around a few zones with writers seeing different values.
>
> Remove it entirely as the later added xfs_cached_zone actually does a
> much better job enforcing the locality as the zone is associated with the
> inode in the MRU cache as soon as the zone is selected.
>
> Fixes: 4e4d52075577 ("xfs: add the zoned space allocator")
> Signed-off-by: Christoph Hellwig <hch@lst.de>
I ran several write & overwrite workloads with this. No problems detected.
So:
Tested-by: Damien Le Moal <dlemoal@kernel.org>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2025-08-19 5:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-18 5:06 zoned allocator fixes Christoph Hellwig
2025-08-18 5:06 ` [PATCH 1/3] xfs: remove xfs_last_used_zone Christoph Hellwig
2025-08-18 13:05 ` Hans Holmberg
2025-08-19 5:56 ` Damien Le Moal [this message]
2025-08-18 5:06 ` [PATCH 2/3] xfs: kick off inodegc when failing to reserve zoned blocks Christoph Hellwig
2025-08-18 13:05 ` Hans Holmberg
2025-08-18 5:06 ` [PATCH 3/3] xfs: reject swapon for inodes on a zoned file system earlier Christoph Hellwig
2025-08-18 13:06 ` Hans Holmberg
2025-08-19 7:17 ` Damien Le Moal
2025-08-19 13:11 ` zoned allocator fixes Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeaa9d62-cff3-49eb-835b-3d0e3d7180fc@kernel.org \
--to=dlemoal@kernel.org \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=hans.holmberg@wdc.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).