Re: [PATCH v2] xfs: Fix the return value of xfs_rtcopy_summary()

["Nirjhar Roy (IBM)" <nirjhar.roy.lists@gmail.com>]

On 12/17/25 21:57, Darrick J. Wong wrote:
> On Wed, Dec 17, 2025 at 08:11:33PM +0530, Nirjhar Roy (IBM) wrote:
>> xfs_rtcopy_summary() should return the appropriate error code
>> instead of always returning 0. The caller of this function which is
>> xfs_growfs_rt_bmblock() is already handling the error.
>>
> Please add
> Cc: <stable@vger.kernel.org> # v6.7
>
> so this can be autobackported

Okay, thank you. Resent it with the Cc tag.

--NR

>
> --D
>
>> Fixes: e94b53ff699c ("xfs: cache last bitmap block in realtime allocator")
>> Signed-off-by: Nirjhar Roy (IBM) <nirjhar.roy.lists@gmail.com>
>> Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
>> ---
>>   fs/xfs/xfs_rtalloc.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/xfs/xfs_rtalloc.c b/fs/xfs/xfs_rtalloc.c
>> index 6907e871fa15..bc88b965e909 100644
>> --- a/fs/xfs/xfs_rtalloc.c
>> +++ b/fs/xfs/xfs_rtalloc.c
>> @@ -126,7 +126,7 @@ xfs_rtcopy_summary(
>>   	error = 0;
>>   out:
>>   	xfs_rtbuf_cache_relse(oargs);
>> -	return 0;
>> +	return error;
>>   }
>>   /*
>>    * Mark an extent specified by start and len allocated.
>> -- 
>> 2.43.5
>>
>>
-- 
Nirjhar Roy
Linux Kernel Developer
IBM, Bangalore