* [PATCH v2] xfs: Fix the return value of xfs_rtcopy_summary()
@ 2025-12-17 14:41 Nirjhar Roy (IBM)
2025-12-17 16:27 ` Darrick J. Wong
0 siblings, 1 reply; 3+ messages in thread
From: Nirjhar Roy (IBM) @ 2025-12-17 14:41 UTC (permalink / raw)
To: linux-xfs; +Cc: ritesh.list, ojaswin, djwong, hch, nirjhar.roy.lists
xfs_rtcopy_summary() should return the appropriate error code
instead of always returning 0. The caller of this function which is
xfs_growfs_rt_bmblock() is already handling the error.
Fixes: e94b53ff699c ("xfs: cache last bitmap block in realtime allocator")
Signed-off-by: Nirjhar Roy (IBM) <nirjhar.roy.lists@gmail.com>
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
---
fs/xfs/xfs_rtalloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/xfs/xfs_rtalloc.c b/fs/xfs/xfs_rtalloc.c
index 6907e871fa15..bc88b965e909 100644
--- a/fs/xfs/xfs_rtalloc.c
+++ b/fs/xfs/xfs_rtalloc.c
@@ -126,7 +126,7 @@ xfs_rtcopy_summary(
error = 0;
out:
xfs_rtbuf_cache_relse(oargs);
- return 0;
+ return error;
}
/*
* Mark an extent specified by start and len allocated.
--
2.43.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] xfs: Fix the return value of xfs_rtcopy_summary()
2025-12-17 14:41 [PATCH v2] xfs: Fix the return value of xfs_rtcopy_summary() Nirjhar Roy (IBM)
@ 2025-12-17 16:27 ` Darrick J. Wong
2025-12-17 16:38 ` Nirjhar Roy (IBM)
0 siblings, 1 reply; 3+ messages in thread
From: Darrick J. Wong @ 2025-12-17 16:27 UTC (permalink / raw)
To: Nirjhar Roy (IBM); +Cc: linux-xfs, ritesh.list, ojaswin, hch
On Wed, Dec 17, 2025 at 08:11:33PM +0530, Nirjhar Roy (IBM) wrote:
> xfs_rtcopy_summary() should return the appropriate error code
> instead of always returning 0. The caller of this function which is
> xfs_growfs_rt_bmblock() is already handling the error.
>
Please add
Cc: <stable@vger.kernel.org> # v6.7
so this can be autobackported
--D
> Fixes: e94b53ff699c ("xfs: cache last bitmap block in realtime allocator")
> Signed-off-by: Nirjhar Roy (IBM) <nirjhar.roy.lists@gmail.com>
> Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
> ---
> fs/xfs/xfs_rtalloc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_rtalloc.c b/fs/xfs/xfs_rtalloc.c
> index 6907e871fa15..bc88b965e909 100644
> --- a/fs/xfs/xfs_rtalloc.c
> +++ b/fs/xfs/xfs_rtalloc.c
> @@ -126,7 +126,7 @@ xfs_rtcopy_summary(
> error = 0;
> out:
> xfs_rtbuf_cache_relse(oargs);
> - return 0;
> + return error;
> }
> /*
> * Mark an extent specified by start and len allocated.
> --
> 2.43.5
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] xfs: Fix the return value of xfs_rtcopy_summary()
2025-12-17 16:27 ` Darrick J. Wong
@ 2025-12-17 16:38 ` Nirjhar Roy (IBM)
0 siblings, 0 replies; 3+ messages in thread
From: Nirjhar Roy (IBM) @ 2025-12-17 16:38 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: linux-xfs, ritesh.list, ojaswin, hch
On 12/17/25 21:57, Darrick J. Wong wrote:
> On Wed, Dec 17, 2025 at 08:11:33PM +0530, Nirjhar Roy (IBM) wrote:
>> xfs_rtcopy_summary() should return the appropriate error code
>> instead of always returning 0. The caller of this function which is
>> xfs_growfs_rt_bmblock() is already handling the error.
>>
> Please add
> Cc: <stable@vger.kernel.org> # v6.7
>
> so this can be autobackported
Okay, thank you. Resent it with the Cc tag.
--NR
>
> --D
>
>> Fixes: e94b53ff699c ("xfs: cache last bitmap block in realtime allocator")
>> Signed-off-by: Nirjhar Roy (IBM) <nirjhar.roy.lists@gmail.com>
>> Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
>> ---
>> fs/xfs/xfs_rtalloc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/xfs/xfs_rtalloc.c b/fs/xfs/xfs_rtalloc.c
>> index 6907e871fa15..bc88b965e909 100644
>> --- a/fs/xfs/xfs_rtalloc.c
>> +++ b/fs/xfs/xfs_rtalloc.c
>> @@ -126,7 +126,7 @@ xfs_rtcopy_summary(
>> error = 0;
>> out:
>> xfs_rtbuf_cache_relse(oargs);
>> - return 0;
>> + return error;
>> }
>> /*
>> * Mark an extent specified by start and len allocated.
>> --
>> 2.43.5
>>
>>
--
Nirjhar Roy
Linux Kernel Developer
IBM, Bangalore
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-12-17 16:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-17 14:41 [PATCH v2] xfs: Fix the return value of xfs_rtcopy_summary() Nirjhar Roy (IBM)
2025-12-17 16:27 ` Darrick J. Wong
2025-12-17 16:38 ` Nirjhar Roy (IBM)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox