From: Carlos Maiolino <cem@kernel.org>
To: Long Li <leo.lilong@huawei.com>
Cc: djwong@kernel.org, linux-xfs@vger.kernel.org,
david@fromorbit.com, yi.zhang@huawei.com, houtao1@huawei.com,
yangerkun@huawei.com, lonuxli.64@gmail.com
Subject: Re: [PATCH 0/3] xfs: handle ERR_PTR return from bio_split
Date: Tue, 21 Apr 2026 10:29:10 +0200 [thread overview]
Message-ID: <aec1GGrtAYLM20lM@nidhogg.toxiclabs.cc> (raw)
In-Reply-To: <20260418092715.375850-1-leo.lilong@huawei.com>
On Sat, Apr 18, 2026 at 05:27:12PM +0800, Long Li wrote:
> bio_split() now returns ERR_PTR() on failure rather than NULL. xfs code
> currently ignores the return value of bio_split() and dereferences it
> unconditionally, which will crash if bio_split() returns an error pointer.
>
> Add an IS_ERR() check after bio_split(), and perform corresponding error
> handling.
>
> Long Li (3):
> xfs: handle ERR_PTR return from bio_split in xfs_buf_submit_bio
> xfs: handle ERR_PTR return from bio_split in xlog_write_iclog
> xfs: handle ERR_PTR return from bio_split in xfs_zone_gc_split_write
All those patches should be merged into a single patch. You don't need a single
patch for each function just to handle the same update.
>
> fs/xfs/xfs_buf.c | 6 ++++++
> fs/xfs/xfs_log.c | 2 ++
> fs/xfs/xfs_zone_gc.c | 10 +++++++++-
> 3 files changed, 17 insertions(+), 1 deletion(-)
>
> --
> 2.39.2
>
>
prev parent reply other threads:[~2026-04-21 8:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-18 9:27 [PATCH 0/3] xfs: handle ERR_PTR return from bio_split Long Li
2026-04-18 9:27 ` [PATCH 1/3] xfs: handle ERR_PTR return from bio_split in xfs_buf_submit_bio Long Li
2026-04-21 8:18 ` Donald Douwsma
2026-04-18 9:27 ` [PATCH 2/3] xfs: handle ERR_PTR return from bio_split in xlog_write_iclog Long Li
2026-04-18 9:27 ` [PATCH 3/3] xfs: handle ERR_PTR return from bio_split in xfs_zone_gc_split_write Long Li
2026-04-21 8:29 ` Carlos Maiolino [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aec1GGrtAYLM20lM@nidhogg.toxiclabs.cc \
--to=cem@kernel.org \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=houtao1@huawei.com \
--cc=leo.lilong@huawei.com \
--cc=linux-xfs@vger.kernel.org \
--cc=lonuxli.64@gmail.com \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox