Re: [PATCH] xfs: sanitize da node pad field on write

Yuto Ohnuki
2026-04-23T07:50:03Z

On Wed, Apr 22, 2026 at 07:52:39AM +1000, Dave Chinner wrote:
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/fs/xfs/libxfs/xfs_da_btree.c b/fs/xfs/libxfs/xfs_da_btree.c
> > index ad801b7bd2dd..f6054a47d24c 100644
> > --- a/fs/xfs/libxfs/xfs_da_btree.c
> > +++ b/fs/xfs/libxfs/xfs_da_btree.c
> > @@ -318,6 +318,8 @@ xfs_da3_node_write_verify(
> > if (bip)
> > hdr3->info.lsn = cpu_to_be64(bip->bli_item.li_lsn);
> >
> > + hdr3->__pad32 = 0;
> > +
>
> Please add a comment explaining why the padding is being written
> unconditionally here. By itself like this it makes no sense at all.
>
> -Dave.
> --
> Dave Chinner
> dgc@kernel.org

Thanks for the advice. I'll add the comment and send as v2.

Yuto Ohnuki

Amazon Web Services EMEA SARL, 38 avenue John F. Kennedy, L-1855 Luxembourg, R.C.S. Luxembourg B186284

Amazon Web Services EMEA SARL, Irish Branch, One Burlington Plaza, Burlington Road, Dublin 4, Ireland, branch registration number 908705