Linux XFS filesystem development
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: aalbersh@kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/3] platform_defs.h: fix __counted_by_ptr annotation
Date: Fri, 8 May 2026 01:56:23 -0700	[thread overview]
Message-ID: <af2lN1mpbsExz7oz@infradead.org> (raw)
In-Reply-To: <177819182658.3486034.17713563256078765686.stgit@frogsfrogsfrogs>

On Thu, May 07, 2026 at 03:11:27PM -0700, Darrick J. Wong wrote:
> diff --git a/include/platform_defs.h b/include/platform_defs.h
> index 5a829db66e0899..5d1bfb1baf94db 100644
> --- a/include/platform_defs.h
> +++ b/include/platform_defs.h
> @@ -331,6 +331,8 @@ struct kvec {
>  #endif
>  
>  /* xfs_attr.h */
> +#ifndef __counted_by_ptr
>  #define __counted_by_ptr(member)
> +#endif

As a fix this is obviously ok, but I wonder if we should provide
the full kernel version here that actually checks?  Or just not
bother as sooner or later the kernel version will be in most
builds?

Also maybe add a comment that we'll pick this up from kernel
headers from 7.1 or newer?


  reply	other threads:[~2026-05-08  8:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-07 22:11 [PATCHSET 1/2] xfsprogs: various bug fixes for 7.1 Darrick J. Wong
2026-05-07 22:11 ` [PATCH 1/3] platform_defs.h: fix __counted_by_ptr annotation Darrick J. Wong
2026-05-08  8:56   ` Christoph Hellwig [this message]
2026-05-07 22:11 ` [PATCH 2/3] xfs_scrub_all: remove dead code Darrick J. Wong
2026-05-08  8:56   ` Christoph Hellwig
2026-05-07 22:11 ` [PATCH 3/3] xfs_scrub: " Darrick J. Wong
2026-05-08  8:56   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=af2lN1mpbsExz7oz@infradead.org \
    --to=hch@infradead.org \
    --cc=aalbersh@kernel.org \
    --cc=djwong@kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox