From: Christoph Hellwig <hch@infradead.org>
To: Pankaj Raghav <p.raghav@samsung.com>
Cc: linux-xfs@vger.kernel.org, bfoster@redhat.com, lukas@herbolt.com,
"Darrick J . Wong" <djwong@kernel.org>,
dgc@kernel.org, gost.dev@samsung.com, pankaj.raghav@linux.dev,
andres@anarazel.de, kundan.kumar@samsung.com, cem@kernel.org,
hch@infradead.org
Subject: Re: [PATCH v4 1/2] xfs: add xfs_bmap_alloc_or_convert_range function
Date: Fri, 8 May 2026 02:01:50 -0700 [thread overview]
Message-ID: <af2mfgd0DQTbAahK@infradead.org> (raw)
In-Reply-To: <20260501112026.673609-2-p.raghav@samsung.com>
> I feel like xfs_bmap_alloc_or_convert_range() has become a bit big and
> logic repeated, should we rethink of going back to the original solution? [1]
>
> [1] https://lore.kernel.org/linux-xfs/20260310194245.848034-2-lukas@herbolt.com/
Looking at the changes here there is almost no shared logic between
the two uses, which doesn't make core "sharing" look useful when there
is nothing left to share.
next prev parent reply other threads:[~2026-05-08 9:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-01 11:20 [PATCH v4 0/2] add FALLOC_FL_WRITE_ZEROES support to xfs Pankaj Raghav
2026-05-01 11:20 ` [PATCH v4 1/2] xfs: add xfs_bmap_alloc_or_convert_range function Pankaj Raghav
2026-05-08 9:01 ` Christoph Hellwig [this message]
2026-05-01 11:20 ` [PATCH v4 2/2] xfs: add support for FALLOC_FL_WRITE_ZEROES Pankaj Raghav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af2mfgd0DQTbAahK@infradead.org \
--to=hch@infradead.org \
--cc=andres@anarazel.de \
--cc=bfoster@redhat.com \
--cc=cem@kernel.org \
--cc=dgc@kernel.org \
--cc=djwong@kernel.org \
--cc=gost.dev@samsung.com \
--cc=kundan.kumar@samsung.com \
--cc=linux-xfs@vger.kernel.org \
--cc=lukas@herbolt.com \
--cc=p.raghav@samsung.com \
--cc=pankaj.raghav@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox