From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Michael Bommarito <michael.bommarito@gmail.com>,
Carlos Maiolino <cem@kernel.org>,
linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xfs: detect cycles in recovered unlinked inode lists
Date: Tue, 19 May 2026 01:30:37 -0700 [thread overview]
Message-ID: <agwfrZAchLLFX7c7@infradead.org> (raw)
In-Reply-To: <20260519050235.GI9568@frogsfrogsfrogs>
On Mon, May 18, 2026 at 10:02:35PM -0700, Darrick J. Wong wrote:
> (Does xfs_repair fix the problem if the mount fails?)
More importantly, what are we trying to fix here? What is the
motivation? And how are we going to test this code, as right now
we trade a potential issue with a crafted malicious image (which isn't
our usual threat model) against adding new code run at mountime without
any test coverage.
next prev parent reply other threads:[~2026-05-19 8:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-18 1:31 [PATCH] xfs: detect cycles in recovered unlinked inode lists Michael Bommarito
2026-05-19 5:02 ` Darrick J. Wong
2026-05-19 8:30 ` Christoph Hellwig [this message]
2026-05-19 12:48 ` Michael Bommarito
2026-05-20 12:19 ` Carlos Maiolino
2026-05-20 12:46 ` Michael Bommarito
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agwfrZAchLLFX7c7@infradead.org \
--to=hch@infradead.org \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=michael.bommarito@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox