From: Christoph Hellwig <hch@infradead.org>
To: Pankaj Raghav <pankaj.raghav@linux.dev>
Cc: Pankaj Raghav <p.raghav@samsung.com>,
linux-xfs@vger.kernel.org, dgc@kernel.org, bfoster@redhat.com,
lukas@herbolt.com, "Darrick J . Wong" <djwong@kernel.org>,
gost.dev@samsung.com, andres@anarazel.de
Subject: Re: [PATCH v5 2/2] xfs: add support for FALLOC_FL_WRITE_ZEROES
Date: Tue, 9 Jun 2026 22:56:25 -0700 [thread overview]
Message-ID: <aij8idPnIDnDZVvb@infradead.org> (raw)
In-Reply-To: <7084832c-800b-4248-aaee-3da5ea266c1f@linux.dev>
On Mon, Jun 08, 2026 at 12:20:29PM +0200, Pankaj Raghav wrote:
> Sashiko reported:
> On 32-bit systems where size_t is 32 bits, lengths exceeding 4GB will be
> truncated, which might cause the on-disk inode size to be permanently updated
> to a severely incorrect smaller size.
>
> So a simple fix would be the following as we already store the value of offset + len locally:
xfs_setfilesize only cares about offset and len vs the final size
for tracing, so this works fine. Not sure if we care about the exact
tracing here. The other option would be to extend the sizse of the len
argument.
prev parent reply other threads:[~2026-06-10 5:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-04 10:14 [PATCH v5 0/2] add FALLOC_FL_WRITE_ZEROES support to xfs Pankaj Raghav
2026-06-04 10:14 ` [PATCH v5 1/2] xfs: add an allocation mode to xfs_alloc_file_space() Pankaj Raghav
2026-06-04 10:14 ` [PATCH v5 2/2] xfs: add support for FALLOC_FL_WRITE_ZEROES Pankaj Raghav
2026-06-08 10:20 ` Pankaj Raghav
2026-06-10 5:56 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aij8idPnIDnDZVvb@infradead.org \
--to=hch@infradead.org \
--cc=andres@anarazel.de \
--cc=bfoster@redhat.com \
--cc=dgc@kernel.org \
--cc=djwong@kernel.org \
--cc=gost.dev@samsung.com \
--cc=linux-xfs@vger.kernel.org \
--cc=lukas@herbolt.com \
--cc=p.raghav@samsung.com \
--cc=pankaj.raghav@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox