From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Carlos Maiolino <cem@kernel.org>, xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfs: fix pointer arithmetic error on 32-bit systems
Date: Tue, 9 Jun 2026 22:14:06 -0700 [thread overview]
Message-ID: <aijynolhADA0Gcjl@infradead.org> (raw)
In-Reply-To: <20260610045724.GS6095@frogsfrogsfrogs>
On Tue, Jun 09, 2026 at 09:57:24PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> The translation of the old XFS_BMBT_KEY_ADDR macro into a static
> function is not correct on 32-bit systems because the sizeof() argument
> went from being a xfs_bmbt_key_t (i.e. a struct) to a (struct
> xfs_bmbt_key *) (i.e. a pointer to the same struct). On 64-bit systems
> this turns out ok because they are the same size, but on 32-bit systems
> this is catastrophic because they are not the same size. So far there
> have been no complaints, most likely because the xfs developers urge
> against running it on 32-bit systems. But this needs fixing asap.
Eww. I think we either need working 32-bit CI, or officially mark
32-bit as deprecated..
The fix looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2026-06-10 5:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-10 4:57 [PATCH] xfs: fix pointer arithmetic error on 32-bit systems Darrick J. Wong
2026-06-10 5:14 ` Christoph Hellwig [this message]
2026-06-10 15:37 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aijynolhADA0Gcjl@infradead.org \
--to=hch@infradead.org \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox