Re: [PATCH] xfs: fail recovery on a committed log item with no regions

[Christoph Hellwig <hch@infradead.org>]

On Wed, Jul 01, 2026 at 04:01:38AM -0700, Christoph Hellwig wrote:
> So maybe as a prep-patch remove the existing ASSERT(0), then as
> a second prep patch move the list splicing after the loop:
> 
> 	if (error) {
> 		/*
> 		 * Return the remaining items back to the transaction item list
> 		 * so they can be freed in caller.
>                  */
> 		if (!list_empty(&sort_list))
> 			list_splice_init(&sort_list, &trans->r_itemq);
> 	} else {
> 		ASSERT(list_empty(&sort_list));
> 	}

Actually just always doing the split back might be even better:

	/*
	 * Return the remaining items back to the transaction item list so they
	 * can be freed in caller.  This should only happen when we encountered
	 * an error.
	 */
	if (!list_empty(&sort_list)) {
		ASSERT(error);
		list_splice_init(&sort_list, &trans->r_itemq);
	}