From: Christoph Hellwig <hch@infradead.org>
To: Joanne Koong <joannelkoong@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Fengnan Chang <changfengnan@bytedance.com>,
brauner@kernel.org, djwong@kernel.org, ojaswin@linux.ibm.com,
dgc@kernel.org, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org, lidiangang@bytedance.com,
pankaj.raghav@linux.dev, Brian Foster <bfoster@redhat.com>
Subject: Re: [PATCH v6 3/3] iomap: add simple dio path for small direct I/O
Date: Thu, 2 Jul 2026 07:35:04 -0700 [thread overview]
Message-ID: <akZ3GErzJSTtOn-H@infradead.org> (raw)
In-Reply-To: <CAJnrk1Y3yPeXBeBNo+DjTt8eRN-mc2F9apBCUn+j=GV7GMzi4g@mail.gmail.com>
On Wed, Jul 01, 2026 at 12:35:24PM -0700, Joanne Koong wrote:
> I think it ends up being pretty simple to get it integrated since
> ->iomap_next already contains the logic to only begin the mapping at
> the start and only finish the mapping when the iter has been fully
> consumed, eg
I wonder if this adds overhead that the simple path removed.
As a first step we could look into inlining iomap_iter_advance as it
is pretty trivial, and iomap_iter once the legacy path is gone.
If it still shows overhead for that (I think we'll want Fengnan in the
loop to benchmark that), we could look into a 'need end' flag in the
iter and allow to skip the call to iomap_iter_advance and iomap_iter
if it set. Although I'd be happier if we could avoid that..
Talking about iomap_next - I also wonder iwe should move everything
that isn't the call to ->iter_next into iomap_process, which would
remove any calling overhead for ->iter_next itself.
next prev parent reply other threads:[~2026-07-02 14:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-01 3:32 [PATCH v6 0/3] iomap: add simple dio path for small direct I/O Fengnan Chang
2026-07-01 3:32 ` [PATCH v6 1/3] iomap: factor out iomap_dio_alignment helper Fengnan Chang
2026-07-01 3:32 ` [PATCH v6 2/3] iomap: pass error code to should_report_dio_fserror directly Fengnan Chang
2026-07-01 3:32 ` [PATCH v6 3/3] iomap: add simple dio path for small direct I/O Fengnan Chang
2026-07-01 11:23 ` Christoph Hellwig
2026-07-01 19:35 ` Joanne Koong
2026-07-02 14:35 ` Christoph Hellwig [this message]
2026-07-03 3:05 ` Joanne Koong
2026-07-03 9:13 ` changfengnan
2026-07-03 12:40 ` Christoph Hellwig
2026-07-06 11:09 ` changfengnan
2026-07-06 19:27 ` Joanne Koong
2026-07-03 9:22 ` changfengnan
2026-07-01 12:44 ` [PATCH v6 0/3] " Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akZ3GErzJSTtOn-H@infradead.org \
--to=hch@infradead.org \
--cc=bfoster@redhat.com \
--cc=brauner@kernel.org \
--cc=changfengnan@bytedance.com \
--cc=dgc@kernel.org \
--cc=djwong@kernel.org \
--cc=joannelkoong@gmail.com \
--cc=lidiangang@bytedance.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ojaswin@linux.ibm.com \
--cc=pankaj.raghav@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox