From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Yousef Alhouseen <alhouseenyousef@gmail.com>,
cem@kernel.org, linux-xfs@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] xfs: zero newly allocated btree root space
Date: Thu, 2 Jul 2026 04:05:06 -0700 [thread overview]
Message-ID: <akZF4ib9KpSxnBQ3@infradead.org> (raw)
In-Reply-To: <20260701155234.GF6526@frogsfrogsfrogs>
On Wed, Jul 01, 2026 at 08:52:34AM -0700, Darrick J. Wong wrote:
> > This almost sounds like we should explicitly zero this case just for that
> > particular case. Although Darrick was kinda heading in a different
> > direction and I don't want to start a fight here.
>
> I'm fine with either solution; I simply prefer the one that fixes all
> the current and future "oops we forgot to zero a hidden padding" bugs in
> one action.
Maybe we should avoid creating hidden zero padding to start with? :)
But this is a small allocation, and most of it gets overwritten
while the cache is still hot, so I can live with the unconditional
zeroing. Still feels a bit odd to reach for the big hammer.
next prev parent reply other threads:[~2026-07-02 11:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-30 10:06 [PATCH v2] xfs: zero newly allocated btree root space Yousef Alhouseen
2026-06-30 16:11 ` Darrick J. Wong
2026-06-30 20:39 ` Yousef Alhouseen
2026-07-01 10:56 ` Christoph Hellwig
2026-07-01 15:52 ` Darrick J. Wong
2026-07-02 11:05 ` Christoph Hellwig [this message]
2026-07-02 15:31 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akZF4ib9KpSxnBQ3@infradead.org \
--to=hch@infradead.org \
--cc=alhouseenyousef@gmail.com \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox