From: Christoph Hellwig <hch@infradead.org>
To: Manognya Singuru <msinguru@redhat.com>
Cc: linux-xfs@vger.kernel.org, aalbersh@redhat.com,
"Darrick J. Wong" <djwong@kernel.org>
Subject: Re: [PATCH v2] mdrestore: fix extent length overflow in v2 restore path
Date: Mon, 13 Jul 2026 02:10:00 -0700 [thread overview]
Message-ID: <alSraBI2E3YwS6ZK@infradead.org> (raw)
In-Reply-To: <20260713061808.22518-1-msinguru@redhat.com>
On Mon, Jul 13, 2026 at 11:48:08AM +0530, Manognya Singuru wrote:
> Aisle Research reported that a crafted metadump v2 extent
> length can overflow the signed int used for length,
> leading to incorrect size calculations and a
> potential heap buffer over-read in restore_meta_extent().
>
> Change the length type to uint64_t and ensure all size
> arithmetic in 64-bit before converting to size_t for I/O
> calls.
Looks good, although you can use up all 73 characters for the commit
log..
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2026-07-13 9:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-13 6:18 [PATCH v2] mdrestore: fix extent length overflow in v2 restore path Manognya Singuru
2026-07-13 9:10 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alSraBI2E3YwS6ZK@infradead.org \
--to=hch@infradead.org \
--cc=aalbersh@redhat.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=msinguru@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox