From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: Christoph Egger <siccegge@stud.informatik.uni-erlangen.de>
Cc: hch@infradead.org, xfs-masters@oss.sgi.com,
Reinhard.Tartler@informatik.uni-erlangen.de,
linux-kernel@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: Obsolete config in kernel build system (XFS_TRACE)
Date: Wed, 20 Jan 2010 07:57:23 -0500 (EST) [thread overview]
Message-ID: <alpine.LFD.2.00.1001200756490.19226@localhost> (raw)
In-Reply-To: <20100120125249.GC3580@faui49.informatik.uni-erlangen.de>
On Wed, 20 Jan 2010, Christoph Egger wrote:
> Hi all!
>
> As part of the VAMOS[0] research project at the University of
> Erlangen we're checking referential integrity between kernel KConfig
> options and in-code Conditional blocks.
>
> Git commit 0b1b213fcf3a8486ada99a2bab84ab8c6f51b264 by
> Christoph Hellwig removed all References to CONFIG_XFS_TRACE, which is
> unreferenced from KConfig side from the linux source code so there's
> only a small bit of it left in KBuild. Mayee remove it as well?
>
> ./fs/xfs/Makefile:95
> +++>
>
> xfs-$(CONFIG_XFS_TRACE) += xfs_btree_trace.o
>
> <+++
if the reference is being removed from the Makefile, wouldn't it
also make sense to delete the corresponding source file as well?
rday
--
========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Kernel Pedantry.
Web page: http://crashcourse.ca
Twitter: http://twitter.com/rpjday
========================================================================
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-01-20 12:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-20 12:52 Obsolete config in kernel build system (XFS_TRACE) Christoph Egger
2010-01-20 12:57 ` Robert P. J. Day [this message]
2010-01-20 22:46 ` Dave Chinner
2010-01-21 12:19 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1001200756490.19226@localhost \
--to=rpjday@crashcourse.ca \
--cc=Reinhard.Tartler@informatik.uni-erlangen.de \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=siccegge@stud.informatik.uni-erlangen.de \
--cc=xfs-masters@oss.sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox