From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <xfs-bounces@oss.sgi.com>
Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25])
	by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id
	o0KCvZ7J008800 for <xfs@oss.sgi.com>; Wed, 20 Jan 2010 06:57:36 -0600
Date: Wed, 20 Jan 2010 07:57:23 -0500 (EST)
From: "Robert P. J. Day" <rpjday@crashcourse.ca>
Subject: Re: Obsolete config in kernel build system (XFS_TRACE)
In-Reply-To: <20100120125249.GC3580@faui49.informatik.uni-erlangen.de>
Message-ID: <alpine.LFD.2.00.1001200756490.19226@localhost>
References: <20100120125249.GC3580@faui49.informatik.uni-erlangen.de>
MIME-Version: 1.0
List-Id: XFS Filesystem from SGI <xfs.oss.sgi.com>
List-Unsubscribe: <http://oss.sgi.com/mailman/options/xfs>,
	<mailto:xfs-request@oss.sgi.com?subject=unsubscribe>
List-Archive: <http://oss.sgi.com/pipermail/xfs>
List-Post: <mailto:xfs@oss.sgi.com>
List-Help: <mailto:xfs-request@oss.sgi.com?subject=help>
List-Subscribe: <http://oss.sgi.com/mailman/listinfo/xfs>,
	<mailto:xfs-request@oss.sgi.com?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: xfs-bounces@oss.sgi.com
Errors-To: xfs-bounces@oss.sgi.com
To: Christoph Egger <siccegge@stud.informatik.uni-erlangen.de>
Cc: hch@infradead.org, xfs-masters@oss.sgi.com, Reinhard.Tartler@informatik.uni-erlangen.de, linux-kernel@vger.kernel.org, xfs@oss.sgi.com

On Wed, 20 Jan 2010, Christoph Egger wrote:

> Hi all!
>
> 	As part of the VAMOS[0] research project at the University of
> Erlangen we're checking referential integrity between kernel KConfig
> options and in-code Conditional blocks.
>
> 	Git commit 0b1b213fcf3a8486ada99a2bab84ab8c6f51b264 by
> Christoph Hellwig removed all References to CONFIG_XFS_TRACE, which is
> unreferenced from KConfig side from the linux source code so there's
> only a small bit of it left in KBuild. Mayee remove it as well?
>
> ./fs/xfs/Makefile:95
> +++>
>
> xfs-$(CONFIG_XFS_TRACE)         += xfs_btree_trace.o
>
> <+++

  if the reference is being removed from the Makefile, wouldn't it
also make sense to delete the corresponding source file as well?

rday
--

========================================================================
Robert P. J. Day                               Waterloo, Ontario, CANADA

            Linux Consulting, Training and Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Twitter:                                       http://twitter.com/rpjday
========================================================================

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs