From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id E76B37FAA for ; Tue, 12 Feb 2013 09:37:42 -0600 (CST) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay1.corp.sgi.com (Postfix) with ESMTP id D29988F8050 for ; Tue, 12 Feb 2013 07:37:42 -0800 (PST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id ZnOaGHk5GvpU1alB for ; Tue, 12 Feb 2013 07:37:42 -0800 (PST) Date: Tue, 12 Feb 2013 16:37:37 +0100 (CET) From: =?ISO-8859-15?Q?Luk=E1=A8_Czerner?= Subject: Re: [PATCH] xfs_mkfs: Do not discard if '-N' is provided In-Reply-To: <511A5BAA.5000203@sandeen.net> Message-ID: References: <1360670381-19838-1-git-send-email-lczerner@redhat.com> <511A5BAA.5000203@sandeen.net> MIME-Version: 1.0 List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Eric Sandeen Cc: Lukas Czerner , xfs@oss.sgi.com On Tue, 12 Feb 2013, Eric Sandeen wrote: > Date: Tue, 12 Feb 2013 09:11:38 -0600 > From: Eric Sandeen > To: Lukas Czerner > Cc: xfs@oss.sgi.com > Subject: Re: [PATCH] xfs_mkfs: Do not discard if '-N' is provided > > On 2/12/13 5:59 AM, Lukas Czerner wrote: > > When '-N' is specified we really should not write anything to the > > device, neither we should attempt to discard the device. > > > > This commit fixes xfs_mkfs to not attempt to discard the device in the > > case user specified '-N' flag. > > Thanks, and yes - ouch, this shouldn't happen with -N, that's bad! > > But it doesn't look like this is against the current git tree, > it applies only with a lot of fuzz & offsets. Ah, I've been using git://git.kernel.org/pub/scm/fs/xfs/xfsprogs-dev.git and I can remember that it's not the first time I've realized that I am using wrong repo. Obviously i am not paying a lot of attention to the xfs channel, but does this keep changing, or is it just me ? :) Will resend the patch based on the git://oss.sgi.com/xfs/cmds/xfsprogs.git thanks Eric! -Lukas > > -Eric > > > Signed-off-by: Lukas Czerner > > --- > > mkfs/xfs_mkfs.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c > > index a889620..95e27e0 100644 > > --- a/mkfs/xfs_mkfs.c > > +++ b/mkfs/xfs_mkfs.c > > @@ -2010,7 +2010,7 @@ _("block size %d cannot be smaller than logical sector size %d\n"), > > exit(1); > > } > > > > - if (discard) { > > + if (discard && !Nflag) { > > discard_blocks(xi.ddev, xi.dsize); > > if (xi.rtdev) > > discard_blocks(xi.rtdev, xi.rtsize); > > > > _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs