Re: [PATCH 1/2] fsx: Add fallocate collapse range operation

Dave Chinner
2014-04-03T21:26:45Z

On Wed, Apr 02, 2014 at 05:55:07PM +0200, Lukáš Czerner wrote:
> On Wed, 2 Apr 2014, Lukas Czerner wrote:
>
> > Date: Wed, 2 Apr 2014 17:33:19 +0200
> > From: Lukas Czerner <lczerner@redhat.com>
> > To: xfs@oss.sgi.com
> > Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
> > Lukas Czerner <lczerner@redhat.com>
> > Subject: [PATCH 1/2] fsx: Add fallocate collapse range operation
> >
> > This commit adds fallocate FALLOC_FL_COLLAPSE_RANGE support for fsx.
>
> Btw, this actually makes the fsx fail on ext4 and xfs after a while.
> I was trying to find a problem in fsx itself but I think it is
> actually ok. That means that we could possibly have bugs in ext4 and
> xfs collapse range implementation. More eyes are needed on this!

No surprise, really. As it is, your previous ZERO_RANGE additions
caused problems for XFS, and those are mostly fixed in the 6 patch
series I sent before LSFMM. Hence I wouldn't be surprised if that's
what you are seeing (on XFs, at least) and it's not actually
COLLAPSE_RANGE that is causing problems...

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com