From: Ales Novak <alnovak@suse.cz>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: fix in the setting of logbsize
Date: Sun, 7 Jun 2015 11:16:28 +0200 (CEST) [thread overview]
Message-ID: <alpine.LSU.2.03.1506071054580.20732@suse.cz> (raw)
In-Reply-To: <20150605222257.GY24666@dastard>
On 2015-6-6 00:22, Dave Chinner wrote:
> Can you give more information about the crashes? From this
> description, I do not know whether this is a work around or a fix
> because I don't know what code is actually causing the problem or
> the circumstances in which the crash occurs. Hence I cannot
> determine if your change is the right change to make or whether the
> documetnation is simply wrong and we have a real bug we shoul dbe
> fixing.
The crashes occurred with logsunit=192k and logbsize=256k. xlog_sync() is
calculating in logsunit units:
count = XLOG_LSUNITTOB(log, XLOG_BTOLSUNIT(log, count_init));
With count_init=256k, the calculated roundoff will try to cover that in
two 192k units. This roundoff is passed to the xlog_pack_data() which
walks the buffer and (hopefully) fails when it hits its 256k border.
--
Ales Novak
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2015-06-07 9:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-05 13:28 [PATCH] xfs: fix in the setting of logbsize Ales Novak
2015-06-05 22:22 ` Dave Chinner
2015-06-05 23:03 ` Eric Sandeen
2015-06-06 22:32 ` Dave Chinner
2015-07-03 15:09 ` Ales Novak
2015-06-07 9:16 ` Ales Novak [this message]
2015-06-08 13:04 ` Mark Tinguely
2015-06-25 22:58 ` Ales Novak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.03.1506071054580.20732@suse.cz \
--to=alnovak@suse.cz \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox