From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: cem@kernel.org, stable@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 6/6] xfs: fix bnobt repair space reservation disposal failure
Date: Tue, 18 Aug 2026 23:24:56 -0700 [thread overview]
Message-ID: <aoVMOJX0jvb_vMYB@infradead.org> (raw)
In-Reply-To: <178659862005.833922.13291793696473888206.stgit@frogsfrogsfrogs>
On Wed, Aug 12, 2026 at 10:26:58PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> LOLLM complains that we don't bubble failures from xrep_abt_dispose_one
> upwards in the callstack. A failure to clean up the space used (or
> reserved but not used) by the new bnobt/cntbt should be reported.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2026-08-19 6:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-13 5:24 [PATCHSET 2/2] xfs: LLM-inspired bug fixes, part 6 Darrick J. Wong
2026-08-13 5:25 ` [PATCH 1/6] xfs: fix xfs_rtrmapbt_mem_cursor for non-rmap filesystems Darrick J. Wong
2026-08-19 6:16 ` Christoph Hellwig
2026-08-13 5:25 ` [PATCH 2/6] xfs: preserve owner on in-memory btree creation Darrick J. Wong
2026-08-19 6:17 ` Christoph Hellwig
2026-08-13 5:26 ` [PATCH 3/6] xfs: don't leak new_bp if xfs_btree_bload_drop_buf fails Darrick J. Wong
2026-08-19 6:20 ` Christoph Hellwig
2026-08-13 5:26 ` [PATCH 4/6] xfs: actually recover intended file sizes in xfs_xmi_item_recover_intent Darrick J. Wong
2026-08-19 6:21 ` Christoph Hellwig
2026-08-13 5:26 ` [PATCH 5/6] xfs: don't modify file attributes or poke fsnotify for dry runs Darrick J. Wong
2026-08-19 6:24 ` Christoph Hellwig
2026-08-13 5:26 ` [PATCH 6/6] xfs: fix bnobt repair space reservation disposal failure Darrick J. Wong
2026-08-19 6:24 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aoVMOJX0jvb_vMYB@infradead.org \
--to=hch@infradead.org \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox