Re: [PATCH 01/11] xfs: always call xfs_qm_adjust_dqlimits during quotacheck repair

[Christoph Hellwig <hch@infradead.org>]

On Mon, Sep 14, 2026 at 10:36:49PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
> 
> LOLLM notices that everywhere else in the kernel, a call to
> xfs_qm_adjust_dqlimits precedes every call to xfs_qm_adjust_dqtimers.
> In particular, mount-time quotacheck does this.
> 
> Looking at xfs_qm_adjust_dqlimits, that function is in charge of
> conveying default limits to a dquot if that dquot's limits have been
> zeroed.  That's quite possible in a repair, so let's follow what
> everyone else does and set it.  This requires us to add a new predicate
> to decide if xfs_qm_adjust_dqlimits is likely to reset any of the
> dquot's limits, and to set the dirty flag to true if so.

I'd vote for merging the two functions as they clearly always should
be called together instead.

> A different LOLLM noticed that we have no way to force xchk_commit_dquot
> to call xfs_qm_adjust_dqtimers, so pack that in at the same time.

This feels completely unrelated, and could also use a much more
detailed explanation why we'd want that.