From: Christoph Hellwig <hch@infradead.org>
To: Andrey Albershteyn <aalbersh@kernel.org>
Cc: "Darrick J. Wong" <djwong@kernel.org>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 4/7] libfrog: try to pass struct fs_path objects to quotactl wrapper
Date: Tue, 15 Sep 2026 05:26:40 -0700 [thread overview]
Message-ID: <aqk5gM82hhqq-Upd@infradead.org> (raw)
In-Reply-To: <aqkeeAgNLMFFqgcl@aalbersh-thinkpadx1carbongen13.rmtcz.csb>
On Tue, Sep 15, 2026 at 12:34:33PM +0200, Andrey Albershteyn wrote:
> > + const struct fs_path *mount,
> > + enum xfs_quota_cmd xcommand,
> > + uint xtype,
> > + uint id,
> > + void *addr)
> > +{
> > + return xfsquotactl(xcommand, mount->fs_name, xtype, id, addr);
>
> The xfsquotactl() can be unfolded here and calls may be replaced
> with xfrog_quotactl(), no?
Yeah, looks like we should be able to kill it. But maybe do that
as a follow on cleanup?
next prev parent reply other threads:[~2026-09-15 12:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-14 5:48 [PATCHSET 2/2] xfsprogs: use quotactl_fd when possible Darrick J. Wong
2026-09-14 5:49 ` [PATCH 1/7] libfrog: hoist xfsquotactl out of xfs_quota Darrick J. Wong
2026-09-15 12:24 ` Christoph Hellwig
2026-09-14 5:50 ` [PATCH 2/7] libfrog: clean up xfsquotactl a little bit Darrick J. Wong
2026-09-15 12:25 ` Christoph Hellwig
2026-09-14 5:50 ` [PATCH 3/7] libfrog: enhance struct fs_path to store optional mount fd Darrick J. Wong
2026-09-15 12:25 ` Christoph Hellwig
2026-09-14 5:50 ` [PATCH 4/7] libfrog: try to pass struct fs_path objects to quotactl wrapper Darrick J. Wong
2026-09-15 10:34 ` Andrey Albershteyn
2026-09-15 12:26 ` Christoph Hellwig [this message]
2026-09-15 16:15 ` Darrick J. Wong
2026-09-16 8:33 ` Andrey Albershteyn
2026-09-14 5:50 ` [PATCH 5/7] libfrog: add quotactl_fd support to xfsquotactl Darrick J. Wong
2026-09-15 12:27 ` Christoph Hellwig
2026-09-14 5:51 ` [PATCH 6/7] xfs_quota: open the filesystem mountpoint for quota operations Darrick J. Wong
2026-09-15 12:27 ` Christoph Hellwig
2026-09-14 5:51 ` [PATCH 7/7] xfs_spaceman: port makecfg to use xfsquotactl Darrick J. Wong
2026-09-15 12:28 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqk5gM82hhqq-Upd@infradead.org \
--to=hch@infradead.org \
--cc=aalbersh@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox