From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: aalbersh@kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 3/3] xfs_quota: fix XFS_GETQSTAT parameter pointer
Date: Mon, 21 Sep 2026 01:29:17 -0700 [thread overview]
Message-ID: <arDq3c43kg9hFhL7@infradead.org> (raw)
In-Reply-To: <178996057694.169604.2071446642858108847.stgit@frogsfrogsfrogs>
On Sun, Sep 20, 2026 at 11:14:27PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> LOLLM noticed that XFS_GETQSTAT is supposed to take a pointer to a
> struct fs_quota_stat, not a struct fs_quota_statv. However, quotactl
> call throws away all such nuance by accepting any void pointer, so this
> got broken by the recent refactoring. Fix all that.
Heh. Should we replace xfrog_quotactl with typed variants for each
argument?
For now this fix itself looks good, though:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2026-09-21 8:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 6:13 [PATCHSET 1/2] xfsprogs: various bug fixes for 7.3 Darrick J. Wong
2026-09-21 6:13 ` [PATCH 1/3] xfs_scrub: terminate systemd services if the sysadmin unmounts Darrick J. Wong
2026-09-21 8:25 ` Christoph Hellwig
2026-09-21 6:14 ` [PATCH 2/3] mkfs: allow disabling quota flags Darrick J. Wong
2026-09-21 8:28 ` Christoph Hellwig
2026-09-21 6:14 ` [PATCH 3/3] xfs_quota: fix XFS_GETQSTAT parameter pointer Darrick J. Wong
2026-09-21 8:29 ` Christoph Hellwig [this message]
2026-09-21 22:43 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arDq3c43kg9hFhL7@infradead.org \
--to=hch@infradead.org \
--cc=aalbersh@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox