From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm2-f12.google.com (mail-wm2-f12.google.com [74.125.225.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BE4C4E36F7 for ; Tue, 22 Sep 2026 09:03:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.140 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790067796; cv=none; b=KldHajs8/3uKoVSbQR5W2oJfmgce0Hai4syRmHhGxMHjd8XxXKMgHGa56fV9I7cAvzSTNa54cj2JaUyOsy2LPAJmGZrNY33FcE2pRSU3niJvjhfyxaxNHdzRSC7I+EgPyD6/rkhEHCi9HViiCojONS0KdY+6Mx4QKL7DGFYkzdM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790067796; c=relaxed/simple; bh=3T+/5+/qt9/zQc/iBOuhbw3f+5o3VdTK6NF4SEakQPA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WuSX7SLfVbE/ECAmEss0Lrw5NBg37LW75O/nVg9HnTFCsHrvFmapZUXvDRUf6c5he/v445LqrhGBQ9VB0rkZYHcUSTvt99tsF7+ygtDABNleY3CI50AJtztEIQQEuEWGZ1X1UtaOMo12JJEvHIJKGsnSF1TuPUFqt6YIIFdC6No= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kcVYwDEl; arc=none smtp.client-ip=74.125.225.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kcVYwDEl" Received: by mail-wm2-f12.google.com with SMTP id 5b1f17b1804b1-49b912d822dso26918915e9.2 for ; Tue, 22 Sep 2026 02:03:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790067793; x=1790672593; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=tXgGr2qFh/euRpkCia3YpYMa0+avEGxCjpNyfGxf7Ek=; b=kcVYwDElJJO0Bo4n0d8AYkFG33WJshJCLsbDGXkLKxMQhuBNiSG51dXQ7ZND3m6V42 qQFhYG4CEfG7rkPsBUWynJc4jeS82xjWywOyjwpYwGoNCUudbluxf7DDPB7wdjjOjFUX FqHelefKELTePbP0z/hyJpYo701LO71NmEDxdjb2Pt3q7oMd1FGkDad9fVfL32HFlPCJ Y02YsPvg68CLxaFYMHT/8ZiP/mOJFvKhCkwr+B7j90ILpRmQUugG3ewo18sCzobxJlXC 4Am8OC6JGfrQdJh8EnRBHatHAhUEAqE/de8NwdZM/TvvKgsZOc6BGe4BmC4R1mLQi/x3 u4yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790067793; x=1790672593; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=tXgGr2qFh/euRpkCia3YpYMa0+avEGxCjpNyfGxf7Ek=; b=NzggJpfjAdC1VDhsF7LJ+YN3VsElScJsAvVqU1kexU2YR+Yh/TR9SeAa9eNI84KXje 1ACtMt7MuhDXiFvYFyUX8fDWcw3NeW9ZKuiV+S7gDUqcVXaMsI9uVXAkOp/ITJ651/1g SvxZJSgo44PXS+yVWeHerYRrB2m6AXGcL+4wfi5Oc/J1Jd9fhpl8aY4YF7K6mpDJusji /b8H4pb152W7GLJ2/glXAfb12txo05yPcEhRwxorVBrzBJl2pn5KqoF0aIlxYg/96xzh 6JZ3QFnuZcYYQT+Y2A4cdaCg+caOsS61WJQHLrQIVEBMrDW/LIhqC2b/ZkhZaly3l18Q iaeg== X-Forwarded-Encrypted: i=1; AKwUvBw9Ng1oarvHMXRY7Nizms+kHnFIdoJkTxTut4h/3lAPAmQIErwILrnoHVhp1HhcZ3nyfhlg0jYENXg=@vger.kernel.org X-Gm-Message-State: AFuF++lqibqy3bFOQ2nHwEuVtX86ah4ANRdCjXQ+nfiaiTRiJDW6XIf1 tVu5VHqzqbdsdDBfQAXMiQp9SIN8rtYXqQF9bLnSV1Xrf8xOV8T8Ec64 X-Gm-Gg: AYBFou1h8Wihg27jSH2b6YhQuo/qsl4VuJ9qTXBrlkquz1xHtgmNcry8mpTzGOkqzE0 ty7FTRt9oqS2a6B9bulc6DsC9GCLZz4RP4w66m/nqgudbOLuI7nSWTEKeK7Y+vKyqVRouHb+Nbx mY3AWBWp7m3AuVrWE5C0y2Fgv+7acxXSvvAXUbKu0CMgXYNNT3qeWeTL35ZlWh2M25s/SJ5+Zpr zo35D+q/ssfInx14ZcGW6uWXa3OLsLwDyq6RLpj8aFSbeb58QN0SVNmsq4o/3XQSoZ0uyzZwgUU PEb7e9vbFBktbnLE2h6ya/nPu6v1fJCmgO1mQXUIdXbipAuJp9yrPalA0IxIZus0JvSBOdeU359 Ciwu/psvZIgmLqIrugG8+6SQjwTyC6BF8gR3BFCo/f5hHy5M/5Oam5PvjOn2zlkczt3px7IcyK4 Y42kKMv05xJWqLISuFRBa2qxDDIbrooHL+Pwh4H0/2qboBatBZ/GTbAbjzbhKjrH48NrR00/GZw LNObpBEzqOMShDmiKk+1ZfHGstRO6MYhDEBUE8Yt8ON/BhYcg+seddlxBxTuhf/XKHtIJkpPNNX 4SWj X-Received: by 2002:a05:600c:1385:b0:49c:edd2:855 with SMTP id 5b1f17b1804b1-49fc5673264mr182704015e9.6.1790067793380; Tue, 22 Sep 2026 02:03:13 -0700 (PDT) Received: from andreayoga.localdomain (93-42-14-189.ip84.fastwebnet.it. [93.42.14.189]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fdace7941sm42684265e9.2.2026.09.22.02.03.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Sep 2026 02:03:12 -0700 (PDT) Date: Tue, 22 Sep 2026 11:03:09 +0200 From: Andrea Parri To: Christoph Hellwig Cc: Christian Brauner , "Darrick J . Wong" , Joanne Koong , Brian Foster , Damien Le Moal , Hannes Reinecke , Daniel Gomez , Pankaj Raghav , Dave Chinner , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 1/3] iomap: don't resubmit an ioend after ->writeback_submit() failed Message-ID: References: <20260921083133.2960-1-parri.andrea@gmail.com> <20260921083133.2960-2-parri.andrea@gmail.com> Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: > Do you have a reproducer for this using some kind of error injection? Yes. xfs_reflink_convert_cow() is the only in-tree way xfs_writeback_submit() can fail, so I added a boot param that forces it to return -EIO, reflinked a file, dirtied several widely separated CoW regions so writeback has to submit more than one ioend, and let background writeback run under the fault injector. On the unfixed kernel this reliably hits "list_add double add" in __list_add_valid_or_report(), from the stale ioend's second bio_endio() landing in xfs_end_bio() and relinking it into ip->i_ioend_list. With the fix applied, writeback just fails cleanly and there's no corruption. Happy to describe the harness in more detail if useful, it's throwaway boot-param/script scaffolding, not something I'd want to send as-is. > Overly long line here. Fixed, will rewrap that comment for v2. Thanks! Andrea