From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: cem@kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 01/12] xfs: be extra careful about replacement directory construction
Date: Sun, 27 Sep 2026 23:34:42 -0700 [thread overview]
Message-ID: <aroKgvEG5maAmXg3@infradead.org> (raw)
In-Reply-To: <179057612618.479634.3835896628058983547.stgit@frogsfrogsfrogs>
On Sun, Sep 27, 2026 at 11:16:04PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> In the directory repair code, we have some debug calls that check that
> we never add a duplicate name to (or remove the wrong entry from) the
> new directory structure. LOLLM thinks that we should actually be
> careful about that all users, not just the developer's system, so let's
> do that. We already had ASSERTs in the bailout cases to make problems
> more obvious to the developers.
Does it also explain why? The code does look obviously ok, but a
rationale why we do extra lookups would be kinda useful..
next prev parent reply other threads:[~2026-09-28 6:34 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 6:15 [PATCHSET] xfs: LLM-inspired bug fixes, part 19 Darrick J. Wong
2026-09-28 6:16 ` [PATCH 01/12] xfs: be extra careful about replacement directory construction Darrick J. Wong
2026-09-28 6:34 ` Christoph Hellwig [this message]
2026-09-29 3:59 ` Darrick J. Wong
2026-09-28 6:16 ` [PATCH 02/12] xfs: improve dirent bounds checking in scrub and repair Darrick J. Wong
2026-09-28 6:37 ` Christoph Hellwig
2026-09-29 4:12 ` Darrick J. Wong
2026-09-28 6:16 ` [PATCH 03/12] xfs: abort dirtree repair if the live update hook dies Darrick J. Wong
2026-09-28 6:38 ` Christoph Hellwig
2026-09-28 6:16 ` [PATCH 04/12] xfs: bail out of directory tree repairs on error Darrick J. Wong
2026-09-28 8:07 ` Christoph Hellwig
2026-09-28 6:17 ` [PATCH 05/12] xfs: fix revalidation of xchk_dquot_iter cached mappings Darrick J. Wong
2026-09-28 8:08 ` Christoph Hellwig
2026-09-28 6:17 ` [PATCH 06/12] xfs: don't repair fs summary counters with garbage Darrick J. Wong
2026-09-28 8:08 ` Christoph Hellwig
2026-09-28 6:17 ` [PATCH 07/12] xfs: allow softlimit with no hardlimit in quota scrub Darrick J. Wong
2026-09-28 8:08 ` Christoph Hellwig
2026-09-28 6:17 ` [PATCH 08/12] xfs: assign an owner to scrub_stats_fops Darrick J. Wong
2026-09-28 8:09 ` Christoph Hellwig
2026-09-28 6:18 ` [PATCH 09/12] xfs: fix lost errno returned from xfarray_foliosort Darrick J. Wong
2026-09-28 8:09 ` Christoph Hellwig
2026-09-28 6:18 ` [PATCH 10/12] xfs: fix skipped inode mask handling in iscan Darrick J. Wong
2026-09-28 8:10 ` Christoph Hellwig
2026-09-28 6:18 ` [PATCH 11/12] xfs: don't proceed with xattr repair if the live update fails Darrick J. Wong
2026-09-28 8:10 ` Christoph Hellwig
2026-09-28 6:18 ` [PATCH 12/12] xfs: don't fix the directory tree if " Darrick J. Wong
2026-09-28 8:10 ` Christoph Hellwig
2026-10-08 13:32 ` [PATCHSET] xfs: LLM-inspired bug fixes, part 19 Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aroKgvEG5maAmXg3@infradead.org \
--to=hch@infradead.org \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox