From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Dave Chinner <dgc@kernel.org>, Eric Sandeen <sandeen@redhat.com>,
linux-xfs@vger.kernel.org, cem@kernel.org, djwong@kernel.org,
hch@lst.de
Subject: Re: [PATCH 5/5] xfs: remove status parameter from several btree insert functions
Date: Wed, 14 Oct 2026 06:21:48 -0700 [thread overview]
Message-ID: <as-B7NY2COb-6WRZ@infradead.org> (raw)
In-Reply-To: <de05ef54-e9aa-4616-b9cf-8090e408a4f1@sandeen.net>
On Tue, Oct 13, 2026 at 11:07:41PM -0500, Eric Sandeen wrote:
> > While you are touching all of these, can you convert them to the
> > more common pattern of:
> >
> > error = xfs_btree_insert(cur);
> > if (error)
> > return error;
> >
> > Otherwise the whole series looks good to me.
> That /adds/ lines, what are you talking about! ;)
>
> Sure, I can do that if folks prefer.
I'd much prefer it, thanks.
prev parent reply other threads:[~2026-10-14 13:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-14 1:29 [PATCH RFC 0/5] xfs: Remove redundant btree insert code Eric Sandeen
2026-10-14 1:29 ` [PATCH 1/5] xfs: remove redundant stat checks after xfs_btree_insert() Eric Sandeen
2026-10-14 4:22 ` Eric Sandeen
2026-10-14 1:30 ` [PATCH 2/5] xfs: remove redundant stat checks after xfs_refcount_insert() Eric Sandeen
2026-10-14 1:30 ` [PATCH 3/5] xfs: remove redundant stat checks after xfs_inobt_insert_rec() Eric Sandeen
2026-10-14 1:30 ` [PATCH 4/5] xfs: remove redundant stat check after rcbagbt_insert() Eric Sandeen
2026-10-14 1:30 ` [PATCH 5/5] xfs: remove status parameter from several btree insert functions Eric Sandeen
2026-10-14 3:59 ` Dave Chinner
2026-10-14 4:07 ` Eric Sandeen
2026-10-14 13:21 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=as-B7NY2COb-6WRZ@infradead.org \
--to=hch@infradead.org \
--cc=cem@kernel.org \
--cc=dgc@kernel.org \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox